Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	<quic_bqiang@quicinc.com>
Subject: Re: [PATCH 1/4] wifi: ath11k: remove invalid peer create logic
Date: Thu, 25 Jan 2024 16:44:15 +0000 (UTC)	[thread overview]
Message-ID: <170620105373.504797.9989085853141323864.kvalo@kernel.org> (raw)
In-Reply-To: <20240123025700.2929-2-quic_bqiang@quicinc.com>

Baochen Qiang <quic_bqiang@quicinc.com> wrote:

> In ath11k_mac_op_assign_vif_chanctx(), there is a logic to
> create peer using ar->mac_addr for a STA vdev. This is invalid
> because a STA vdev should have a peer created using AP's
> MAC address. Besides, if we run into that logic, it means a peer
> has already been created earlier, we should not create it again.
> So remove it.
> 
> This is found during code review.
> 
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

4 patches applied to ath-next branch of ath.git, thanks.

171203f0c409 wifi: ath11k: remove invalid peer create logic
629642fa8b25 wifi: ath11k: rename ath11k_start_vdev_delay()
ce59902e56ea wifi: ath11k: avoid forward declaration of ath11k_mac_start_vdev_delay()
9d5f28c1366f wifi: ath11k: fix connection failure due to unexpected peer delete

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240123025700.2929-2-quic_bqiang@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


  parent reply	other threads:[~2024-01-25 16:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23  2:56 [PATCH 0/4] wifi: ath11k: fix connection failure due to unexpected peer delete Baochen Qiang
2024-01-23  2:56 ` [PATCH 1/4] wifi: ath11k: remove invalid peer create logic Baochen Qiang
2024-01-24  2:05   ` Jeff Johnson
2024-01-25 16:43     ` Kalle Valo
2024-01-25 16:44   ` Kalle Valo [this message]
2024-01-23  2:56 ` [PATCH 2/4] wifi: ath11k: rename ath11k_start_vdev_delay() Baochen Qiang
2024-01-24  2:08   ` Jeff Johnson
2024-01-23  2:56 ` [PATCH 3/4] wifi: ath11k: avoid forward declaration of ath11k_mac_start_vdev_delay() Baochen Qiang
2024-01-24  2:09   ` Jeff Johnson
2024-01-23  2:57 ` [PATCH 4/4] wifi: ath11k: fix connection failure due to unexpected peer delete Baochen Qiang
2024-01-24  2:09   ` Jeff Johnson
2024-01-29 18:54 ` [PATCH 0/4] " James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170620105373.504797.9989085853141323864.kvalo@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_bqiang@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox