From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org,
jjohnson@kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 4/4] wifi: ath12k: implement custom wake_tx_queue with flow control
Date: Thu, 13 Aug 2026 09:23:24 -0700 [thread overview]
Message-ID: <170a200e-f0fc-4e8f-a7c6-72294beb185a@oss.qualcomm.com> (raw)
In-Reply-To: <20260811111405.397112-1-jtornosm@redhat.com>
On 8/11/2026 4:14 AM, Jose Ignacio Tornos Martinez wrote:
>>> + spin_lock(&tcl_ring->lock);
>>
>> seems this should be spin_lock_bh() to align with all other callers in the driver.
>
> The outer spin_lock_bh(&tx_ring->wake_tx_lock); already disables BH, so
> spin_lock() for the inner tcl_ring->lock is correct and sufficient. Using
> spin_lock_bh() would redundantly disable BH again.
Yes, but if that outer spinlock is ever removed, the inner spinlock would no
longer be correct. So the defensive pattern is to use _bh in both places, and
both of my AI review agents concur with this practice.
/jeff
next prev parent reply other threads:[~2026-08-13 16:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 10:58 [PATCH v5 0/4] ath11k/ath12k: implement TX flow control Jose Ignacio Tornos Martinez
2026-08-07 10:58 ` [PATCH v5 1/4] wifi: ath11k: use queue mapping for WCN6750 ring selection Jose Ignacio Tornos Martinez
2026-08-07 10:58 ` [PATCH v5 2/4] wifi: ath11k/ath12k: remove skb parameter from get_ring_selector Jose Ignacio Tornos Martinez
2026-08-07 10:58 ` [PATCH v5 3/4] wifi: ath11k: implement custom wake_tx_queue with flow control Jose Ignacio Tornos Martinez
2026-08-08 18:42 ` Jeff Johnson
2026-08-11 10:42 ` Jose Ignacio Tornos Martinez
2026-08-07 10:58 ` [PATCH v5 4/4] wifi: ath12k: " Jose Ignacio Tornos Martinez
2026-08-08 19:29 ` Jeff Johnson
2026-08-11 11:14 ` Jose Ignacio Tornos Martinez
2026-08-13 16:23 ` Jeff Johnson [this message]
2026-08-13 17:25 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170a200e-f0fc-4e8f-a7c6-72294beb185a@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=jtornosm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox