From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'John W. Linville'" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>, <wil6210@qca.qualcomm.com>
Subject: Re: [PATCH 07/12] wireless: wil6210: remove unnecessary pci_set_drvdata()
Date: Sun, 15 Sep 2013 10:46:50 +0300 [thread overview]
Message-ID: <1712658.NzU3oG495s@lx-vladimir> (raw)
In-Reply-To: <00b801ceae18$8e5498c0$aafdca40$%han@samsung.com>
On Tuesday, September 10, 2013 08:26:13 PM Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/wireless/ath/wil6210/pcie_bus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/pcie_bus.c b/drivers/net/wireless/ath/wil6210/pcie_bus.c
> index eb1dc7a..eeceab3 100644
> --- a/drivers/net/wireless/ath/wil6210/pcie_bus.c
> +++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c
> @@ -197,7 +197,6 @@ static void wil_pcie_remove(struct pci_dev *pdev)
> pci_iounmap(pdev, wil->csr);
> pci_release_region(pdev, 0);
> pci_disable_device(pdev);
> - pci_set_drvdata(pdev, NULL);
> }
>
> static DEFINE_PCI_DEVICE_TABLE(wil6210_pcie_ids) = {
>
Here is my
Acked-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
next prev parent reply other threads:[~2013-09-15 7:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-10 11:16 ` [PATCH 01/12] wireless: iwlwifi: " Jingoo Han
2013-09-10 11:30 ` Emmanuel Grumbach
2013-09-10 11:18 ` [PATCH 02/12] wireless: rtlwifi: " Jingoo Han
2013-09-10 14:34 ` Larry Finger
2013-09-10 11:19 ` [PATCH 03/12] wireless: iwlegacy: " Jingoo Han
2013-09-10 11:22 ` [PATCH 04/12] wireless: adm8211: " Jingoo Han
2013-09-10 11:23 ` [PATCH 05/12] wireless: airo: " Jingoo Han
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: " Jingoo Han
2013-09-10 21:56 ` Kalle Valo
2013-09-11 0:32 ` Jingoo Han
2013-09-12 16:23 ` Kalle Valo
2013-09-10 11:26 ` [PATCH 07/12] wireless: wil6210: " Jingoo Han
2013-09-15 7:46 ` Vladimir Kondratiev [this message]
2013-09-10 11:27 ` [PATCH 08/12] wireless: ipw2x00: " Jingoo Han
2013-09-10 11:27 ` [PATCH 09/12] wireless: mwl8k: " Jingoo Han
2013-09-10 11:29 ` [PATCH 10/12] wireless: orinoco: " Jingoo Han
2013-09-10 11:30 ` [PATCH 11/12] wireless: p54pci: " Jingoo Han
2013-09-10 11:32 ` [PATCH 12/12] wireless: rtl818x: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1712658.NzU3oG495s@lx-vladimir \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=jg1.han@samsung.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).