[PATCH] wifi: brcm80211: remove unused structs

[PATCH] wifi: brcm80211: remove unused structs

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'brcmf_pcie_core_info' was added in
commit 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.")
but never used.

'brcms_c_bit_desc' last use was removed in
commit cdf4352f5c59 ("brcmsmac: Improve tx trace and debug support").

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 5 -----
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 6 ------
 2 files changed, 11 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 06698a714b52..ce482a3877e9 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -313,11 +313,6 @@ struct brcmf_pcie_shared_info {
 	u8 version;
 };
 
-struct brcmf_pcie_core_info {
-	u32 base;
-	u32 wrapbase;
-};
-
 #define BRCMF_OTP_MAX_PARAM_LEN 16
 
 struct brcmf_otp_params {
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
index 34460b5815d0..4576b18fcd97 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
@@ -234,12 +234,6 @@
 /* max # tx status to process in wlc_txstatus() */
 #define TXSBND				8
 
-/* brcmu_format_flags() bit description structure */
-struct brcms_c_bit_desc {
-	u32 bit;
-	const char *name;
-};
-
 /*
  * The following table lists the buffer memory allocated to xmt fifos in HW.
  * the size is in units of 256bytes(one block), total size is HW dependent
-- 
2.45.1

Re: [PATCH] wifi: brcm80211: remove unused structs

[Arend van Spriel]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

On 5/27/2024 1:45 AM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'brcmf_pcie_core_info' was added in
> commit 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.")
> but never used.
> 
> 'brcms_c_bit_desc' last use was removed in
> commit cdf4352f5c59 ("brcmsmac: Improve tx trace and debug support").
> 
> Remove them.

Thanks for cleaning this up.

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 5 -----
>   drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 6 ------
>   2 files changed, 11 deletions(-)

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]

Re: [PATCH] wifi: brcm80211: remove unused structs

[Kalle Valo]

linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'brcmf_pcie_core_info' was added in
> commit 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.")
> but never used.
> 
> 'brcms_c_bit_desc' last use was removed in
> commit cdf4352f5c59 ("brcmsmac: Improve tx trace and debug support").
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Patch applied to wireless-next.git, thanks.

5bcd9a0a5995 wifi: brcm80211: remove unused structs

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240526234553.286773-1-linux@treblig.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches