From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95EEB18654; Tue, 27 Aug 2024 07:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724744984; cv=none; b=JI6dsrHT/W2QCOne2DFZbXaJyqmWfiHhAzCoGdpEVSTYDJJcVuoE6+gqQpcG+3eW7AOGlYBgo8KqyRU89u088+16WgJA7/gxwip5JVwit0j10W6BpHd1vsHmjHbuGUUHA7lWdF4M3ZCNkH3jXai+RvJAps3gyPSKVyU/k6a8+Wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724744984; c=relaxed/simple; bh=q86gNMgXVgcdIVPlsT0WGRi200SjWYGch5bmRTjnh3k=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=ZgkRLhp4NCBDp792tXCsIh9taDKjZercA+1rz6rO83os7NAFo2nWYDZjIy+gA+H9+btFUtMe0/skf23ISBT04wPbZ7iL5BCDJxJSX80GOVRk1suQAxVdX/ygiGI1dGMdLmDCqYbmN75edeBrOEKIQ1NpQyXtEyXAMzLaaTatQ1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=upEQcUvg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="upEQcUvg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2262C8B7A1; Tue, 27 Aug 2024 07:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724744984; bh=q86gNMgXVgcdIVPlsT0WGRi200SjWYGch5bmRTjnh3k=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=upEQcUvgrhfXD1WnWb8VQdcjGaWeYCG3/WiqEuzxpuDuWMaaooh6bLIZsH4V8biew gBL2VXSNcj34BCHNVMdbg/6qkh7WuFqPLReHO1TgpXrz7bB8RnmrHDayxKB4z4onx1 j0hZIi5NazAbKh/jWO/2CPafPElVlRNYyhNZnfkz3R2h7QuNmL89XODqCOHVggIkL4 8VAjPQKgluOF8jk9VwTnSCqiS7WV3QVPmUQp7renX5mFp6LCiDOaMa59WJs/3vaQFp g501Uy2bN2M3wsbt36M9ljM9EzmgXcs1HZlkoedYIqhONQUFCir1gQ17nAdqXjuR1L RXxOm3h5cQYvA== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: wifi: wfx: repair open network AP mode From: Kalle Valo In-Reply-To: <20240823131521.3309073-1-alexander.sverdlin@siemens.com> References: <20240823131521.3309073-1-alexander.sverdlin@siemens.com> To: "A. Sverdlin" Cc: linux-wireless@vger.kernel.org, Alexander Sverdlin , =?utf-8?b?SsOpcsO0?= =?utf-8?b?bWUgUG91aWxsZXI=?= , Dmitry Antipov , stable@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <172474498108.2876569.5337520970531650493.kvalo@kernel.org> Date: Tue, 27 Aug 2024 07:49:42 +0000 (UTC) "A. Sverdlin" wrote: > From: Alexander Sverdlin > > RSN IE missing in beacon is normal in open networks. > Avoid returning -EINVAL in this case. > > Steps to reproduce: > > $ cat /etc/wpa_supplicant.conf > network={ > ssid="testNet" > mode=2 > key_mgmt=NONE > } > > $ wpa_supplicant -iwlan0 -c /etc/wpa_supplicant.conf > nl80211: Beacon set failed: -22 (Invalid argument) > Failed to set beacon parameters > Interface initialization failed > wlan0: interface state UNINITIALIZED->DISABLED > wlan0: AP-DISABLED > wlan0: Unable to setup interface. > Failed to initialize AP interface > > After the change: > > $ wpa_supplicant -iwlan0 -c /etc/wpa_supplicant.conf > Successfully initialized wpa_supplicant > wlan0: interface state UNINITIALIZED->ENABLED > wlan0: AP-ENABLED > > Cc: stable@vger.kernel.org > Fixes: fe0a7776d4d1 ("wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap()") > Signed-off-by: Alexander Sverdlin > Reviewed-by: Jérôme Pouiller Patch applied to wireless.git, thanks. 6d30bb88f623 wifi: wfx: repair open network AP mode -- https://patchwork.kernel.org/project/linux-wireless/patch/20240823131521.3309073-1-alexander.sverdlin@siemens.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches https://docs.kernel.org/process/submitting-patches.html