From: Kalle Valo <kvalo@kernel.org>
To: Yuan Can <yuancan@huawei.com>
Cc: <jerome.pouiller@silabs.com>, <gregkh@linuxfoundation.org>,
<linux-wireless@vger.kernel.org>, <yuancan@huawei.com>
Subject: Re: [PATCH] wifi: wfx: Fix error handling in wfx_core_init()
Date: Thu, 31 Oct 2024 14:18:53 +0000 (UTC) [thread overview]
Message-ID: <173038433204.539202.14907836259811918738.kvalo@kernel.org> (raw)
In-Reply-To: <20241022090453.84679-1-yuancan@huawei.com>
Yuan Can <yuancan@huawei.com> wrote:
> The wfx_core_init() returns without checking the retval from
> sdio_register_driver().
> If the sdio_register_driver() failed, the module failed to install,
> leaving the wfx_spi_driver not unregistered.
>
> Fixes: a7a91ca5a23d ("staging: wfx: add infrastructure for new driver")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Patch applied to wireless-next.git, thanks.
3b88a9876779 wifi: wfx: Fix error handling in wfx_core_init()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20241022090453.84679-1-yuancan@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-10-31 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 9:04 [PATCH] wifi: wfx: Fix error handling in wfx_core_init() Yuan Can
2024-10-22 9:38 ` Greg KH
2024-10-22 10:15 ` Jérôme Pouiller
2024-10-31 14:18 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173038433204.539202.14907836259811918738.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox