From: David Howells <dhowells@redhat.com>
To: seanm@seanm.ca, gregkh@suse.de, viro@ZenIV.linux.org.uk
Cc: dhowells@redhat.com, awong1@novell.com, linux-wireless@vger.kernel.org
Subject: The rtl8192e procfs-based debug interface seems very broken
Date: Mon, 08 Apr 2013 11:02:44 +0100 [thread overview]
Message-ID: <17570.1365415364@warthog.procyon.org.uk> (raw)
The procfs-based debug interface in:
drivers/staging/rtl8192e/rtl8192e/rtl_debug.c
seems to be very broken because:
(1) proc_get_stats_ap() walks ieee->network_list with no locking.
(2) There is no locking against normal driver operations whilst we wangle the
device registers. Admittedly, this may not modify the device state since
all the pages appear memory-mapped rather than bank-swapped - but if
there are any read-to-ack type regs, then this is bad.
(3) We send the device commands and await replies - again without locking
against the normal driver (eg. proc_get_cam_register_*()).
David
next reply other threads:[~2013-04-08 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 10:02 David Howells [this message]
2013-04-08 22:31 ` The rtl8192e procfs-based debug interface seems very broken Larry Finger
2013-04-08 22:46 ` Sean MacLennan
2013-04-08 22:59 ` Larry Finger
2013-04-09 1:18 ` Sean MacLennan
2013-04-09 1:28 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17570.1365415364@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=awong1@novell.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=seanm@seanm.ca \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).