Remove TL-WN722N V2 from untested devices

Remove TL-WN722N V2 from untested devices

[Алексей Смирнов]

I have been using this Wi-Fi dongle for many years now and have had no
problems with it. The device is quite old and known, dumping its efuse to
the log and asking the user to send the results to Jes.Sorensen@gmail.com
on every boot makes little sense. Please apply:

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
b/drivers/net/wireless/realtek/rtl8xxxu/core.c
index 831b5025c634..113e01df0902 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
@@ -7815,7 +7815,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
                        untested = 0;
                break;
        case 0x2357:
-               if (id->idProduct == 0x0109 || id->idProduct == 0x0135)
+               if (id->idProduct == 0x0109 || id->idProduct == 0x010c
|| id->idProduct == 0x0135)
                        untested = 0;
                break;
        case 0x0b05:

RE: Remove TL-WN722N V2 from untested devices

[Ping-Ke Shih]

Алексей Смирнов <debugger94@gmail.com> wrote:
> I have been using this Wi-Fi dongle for many years now and have had no
> problems with it. The device is quite old and known, dumping its efuse to
> the log and asking the user to send the results to Jes.Sorensen@gmail.com
> on every boot makes little sense. Please apply:

I'll rephrase commit message when I merge this:

wifi: rtl8xxxu: Remove TL-WN722N V2 (0x2357: 0x010c) from untested devices

This Wi-Fi dongle has been used for many years now and have had no problems
with it. The device is quite old and known, dumping its efuse to the log and
asking the user to send the results to Jes.Sorensen@gmail.com on every boot
makes little sense.

Signed-off-by: Алексей Смирнов <debugger94@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> index 831b5025c634..113e01df0902 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> @@ -7815,7 +7815,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
>                         untested = 0;
>                 break;
>         case 0x2357:
> -               if (id->idProduct == 0x0109 || id->idProduct == 0x0135)
> +               if (id->idProduct == 0x0109 || id->idProduct == 0x010c
> || id->idProduct == 0x0135)
>                         untested = 0;
>                 break;
>         case 0x0b05:

Re: Remove TL-WN722N V2 from untested devices

[Bitterblue Smith]

On 25/08/2025 08:57, Ping-Ke Shih wrote:
> Алексей Смирнов <debugger94@gmail.com> wrote:
>> I have been using this Wi-Fi dongle for many years now and have had no
>> problems with it. The device is quite old and known, dumping its efuse to
>> the log and asking the user to send the results to Jes.Sorensen@gmail.com
>> on every boot makes little sense. Please apply:
> 
> I'll rephrase commit message when I merge this:
> 
> wifi: rtl8xxxu: Remove TL-WN722N V2 (0x2357: 0x010c) from untested devices
> 
> This Wi-Fi dongle has been used for many years now and have had no problems
> with it. The device is quite old and known, dumping its efuse to the log and
> asking the user to send the results to Jes.Sorensen@gmail.com on every boot
> makes little sense.
> 
> Signed-off-by: Алексей Смирнов <debugger94@gmail.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> 
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
>> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
>> index 831b5025c634..113e01df0902 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
>> @@ -7815,7 +7815,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
>>                         untested = 0;
>>                 break;
>>         case 0x2357:
>> -               if (id->idProduct == 0x0109 || id->idProduct == 0x0135)
>> +               if (id->idProduct == 0x0109 || id->idProduct == 0x010c
>> || id->idProduct == 0x0135)
>>                         untested = 0;
>>                 break;
>>         case 0x0b05:
> 

I propose we simply remove the entire list of tested devices. It's not
particularly useful to tell people to report if a device works or not.
If it doesn't work they will report it anyway.

RE: Remove TL-WN722N V2 from untested devices

[Ping-Ke Shih]

+ Jes

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> On 25/08/2025 08:57, Ping-Ke Shih wrote:
> > Алексей Смирнов <debugger94@gmail.com> wrote:
> >> I have been using this Wi-Fi dongle for many years now and have had no
> >> problems with it. The device is quite old and known, dumping its efuse to
> >> the log and asking the user to send the results to Jes.Sorensen@gmail.com
> >> on every boot makes little sense. Please apply:
> >
> > I'll rephrase commit message when I merge this:
> >
> > wifi: rtl8xxxu: Remove TL-WN722N V2 (0x2357: 0x010c) from untested devices
> >
> > This Wi-Fi dongle has been used for many years now and have had no problems
> > with it. The device is quite old and known, dumping its efuse to the log and
> > asking the user to send the results to Jes.Sorensen@gmail.com on every boot
> > makes little sense.
> >
> > Signed-off-by: Алексей Смирнов <debugger94@gmail.com>
> > Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> >
> >>
> >> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> >> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> >> index 831b5025c634..113e01df0902 100644
> >> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> >> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> >> @@ -7815,7 +7815,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
> >>                         untested = 0;
> >>                 break;
> >>         case 0x2357:
> >> -               if (id->idProduct == 0x0109 || id->idProduct == 0x0135)
> >> +               if (id->idProduct == 0x0109 || id->idProduct == 0x010c
> >> || id->idProduct == 0x0135)
> >>                         untested = 0;
> >>                 break;
> >>         case 0x0b05:
> >
> 
> I propose we simply remove the entire list of tested devices. It's not
> particularly useful to tell people to report if a device works or not.
> If it doesn't work they will report it anyway.

This untested flag was added since 2015 at first commit, but I wasn't here
at that time. Jes, could you please comment this untested report of efuse
is still useful now?

Re: Remove TL-WN722N V2 from untested devices

[Ping-Ke Shih]

=?utf-8?b?0JDQu9C10LrRgdC10Lkg0KHQvNC40YDQvdC+0LI=?= <debugger94@gmail.com> wrote:

> I have been using this Wi-Fi dongle for many years now and have had no
> problems with it. The device is quite old and known, dumping its efuse to
> the log and asking the user to send the results to Jes.Sorensen@gmail.com
> on every boot makes little sense. Please apply:
> 
>         case 0x0b05:
> Signed-off-by: Алексей Смирнов <debugger94@gmail.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> index 831b5025c634..113e01df0902 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> @@ -7815,7 +7815,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
>                         untested = 0;
>                 break;
>         case 0x2357:
> -               if (id->idProduct == 0x0109 || id->idProduct == 0x0135)
> +               if (id->idProduct == 0x0109 || id->idProduct == 0x010c
> || id->idProduct == 0x0135)
>                         untested = 0;
>                 break;

Applied 1 patch to rtw-next, thanks.

f46edd92040f wifi: rtl8xxxu: Remove TL-WN722N V2 (0x2357: 0x010c) from untested devices

---
https://github.com/pkshih/rtw.git

RE: Remove TL-WN722N V2 from untested devices

[Ping-Ke Shih]

Ping-Ke Shih <pkshih@realtek.com> wrote:
> + Jes
> 
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> > On 25/08/2025 08:57, Ping-Ke Shih wrote:
> > > Алексей Смирнов <debugger94@gmail.com> wrote:
> > >> I have been using this Wi-Fi dongle for many years now and have had no
> > >> problems with it. The device is quite old and known, dumping its efuse to
> > >> the log and asking the user to send the results to Jes.Sorensen@gmail.com
> > >> on every boot makes little sense. Please apply:
> > >
> > > I'll rephrase commit message when I merge this:
> > >
> > > wifi: rtl8xxxu: Remove TL-WN722N V2 (0x2357: 0x010c) from untested devices
> > >
> > > This Wi-Fi dongle has been used for many years now and have had no problems
> > > with it. The device is quite old and known, dumping its efuse to the log and
> > > asking the user to send the results to Jes.Sorensen@gmail.com on every boot
> > > makes little sense.
> > >
> > > Signed-off-by: Алексей Смирнов <debugger94@gmail.com>
> > > Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> > >
> > >>
> > >> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> index 831b5025c634..113e01df0902 100644
> > >> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> > >> @@ -7815,7 +7815,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
> > >>                         untested = 0;
> > >>                 break;
> > >>         case 0x2357:
> > >> -               if (id->idProduct == 0x0109 || id->idProduct == 0x0135)
> > >> +               if (id->idProduct == 0x0109 || id->idProduct == 0x010c
> > >> || id->idProduct == 0x0135)
> > >>                         untested = 0;
> > >>                 break;
> > >>         case 0x0b05:
> > >
> >
> > I propose we simply remove the entire list of tested devices. It's not
> > particularly useful to tell people to report if a device works or not.
> > If it doesn't work they will report it anyway.
> 
> This untested flag was added since 2015 at first commit, but I wasn't here
> at that time. Jes, could you please comment this untested report of efuse
> is still useful now?
> 

I merged this patch ahead, and we may rely on Martin's patch [1] to get
efuse content, so after that patch gets merged, the 'untested' stuff
can be removed entirely.

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20250826090015.1552939-1-martin.kaistra@linutronix.de/