From: Sujith <Sujith.Manoharan@atheros.com>
To: Luis Rodriguez <lrodriguez@atheros.com>
Cc: Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [ath9k-devel] [PATCH v2 2/2] ath9k: Use GFP_ATOMIC when allocating TX private area
Date: Wed, 3 Dec 2008 10:20:24 +0530 [thread overview]
Message-ID: <18742.4112.665927.756930@gargle.gargle.HOWL> (raw)
In-Reply-To: <43e72e890812022012o7759400mf002f51c0a3f0eb@mail.gmail.com>
Luis Rodriguez wrote:
> ath_test_get_txq() will not return the queue only if the queue is
> getting full. What the check above guarantees is we have at least one
> buffer to run through procesq before disabling the TX queue, otherwise
> the queue won't be be woken up. Or am I missing something? That is,
> say you just have to TX one skb and we hit -ENOMEM on
> ath_tx_setup_buffer() and you disable the queue. How will this queue
> be awoken if this is true in ath_tx_processq():
>
> list_empty(&txq->axq_q)
Ok, makes sense.
But the queue can be obtained from txctl, so that code can be removed.
Sujith
prev parent reply other threads:[~2008-12-03 4:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 3:15 [PATCH v2 0/2] ath9k: few memory fixes Luis R. Rodriguez
2008-12-03 3:15 ` [PATCH v2 1/2] ath9k: Check for pci_map_single() errors Luis R. Rodriguez
2008-12-03 3:15 ` [PATCH v2 2/2] ath9k: Use GFP_ATOMIC when allocating TX private area Luis R. Rodriguez
[not found] ` <18742.299.281327.259785@localhost.localdomain>
2008-12-03 4:12 ` [ath9k-devel] " Luis R. Rodriguez
2008-12-03 4:50 ` Sujith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18742.4112.665927.756930@gargle.gargle.HOWL \
--to=sujith.manoharan@atheros.com \
--cc=Senthilkumar.Balasubramanian@Atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox