From: Sujith <m.sujith@gmail.com>
To: Mats Johannesson <spamcan1@abrasax.se>
Cc: linux-wireless@vger.kernel.org
Subject: [ath9k] 2.6.28-rc7-wl Kernel panic when "iwlist ath0 scan" as root
Date: Sat, 6 Dec 2008 20:22:09 +0530 [thread overview]
Message-ID: <18746.37273.989918.333164@localhost.localdomain> (raw)
In-Reply-To: <20081206113406.734f1d94@loke.fish.not>
Mats Johannesson wrote:
> As the subject says, 2.6.28-rc7-wl git pulled Dec 6 exhibits a kernel
> panic when doing "iwlist ath0 scan" as root under the ath9k driver.
> Machine dead, panic LED blinking.
>
> Scan as normal user is OK.
>
Can you check if this makes any difference ? Thanks.
diff --git a/drivers/net/wireless/ath9k/core.h b/drivers/net/wireless/ath9k/core.h
index ca8ed7d..726d0a3 100644
--- a/drivers/net/wireless/ath9k/core.h
+++ b/drivers/net/wireless/ath9k/core.h
@@ -702,6 +702,7 @@ struct ath_softc {
/* Rate */
struct ieee80211_rate rates[IEEE80211_NUM_BANDS][ATH_RATE_MAX];
struct ath_rate_table *hw_rate_table[ATH9K_MODE_MAX];
+ struct ath_rate_table *cur_rate_table;
u8 sc_protrix;
/* Channel, Band */
diff --git a/drivers/net/wireless/ath9k/rc.c b/drivers/net/wireless/ath9k/rc.c
index 76acd2b..8eec667 100644
--- a/drivers/net/wireless/ath9k/rc.c
+++ b/drivers/net/wireless/ath9k/rc.c
@@ -817,7 +817,7 @@ static void ath_rc_ratefind(struct ath_softc *sc,
struct ath_rate_table *rate_table;
struct ieee80211_tx_rate *rates = tx_info->control.rates;
- rate_table = sc->hw_rate_table[sc->sc_curmode];
+ rate_table = sc->cur_rate_table;
rix = ath_rc_ratefind_ht(sc, ath_rc_priv, rate_table, 1,
is_probe, is_retry);
nrix = rix;
@@ -877,7 +877,7 @@ static void ath_rc_ratefind(struct ath_softc *sc,
if ((sc->sc_curmode == ATH9K_MODE_11NG_HT20) ||
(sc->sc_curmode == ATH9K_MODE_11NG_HT40PLUS) ||
(sc->sc_curmode == ATH9K_MODE_11NG_HT40MINUS)) {
- u8 dot11rate = rate_table->info[rix].dot11rate;
+ u8 dot11rate = rate_table->info[rix].dot11rate;
u8 phy = rate_table->info[rix].phy;
if (i == 4 &&
((dot11rate == 2 && phy == WLAN_RC_PHY_HT_40_SS) ||
@@ -1094,7 +1094,7 @@ static void ath_rc_update_ht(struct ath_softc *sc,
int rate;
u8 last_per;
bool state_change = false;
- struct ath_rate_table *rate_table = sc->hw_rate_table[sc->sc_curmode];
+ struct ath_rate_table *rate_table = sc->cur_rate_table;
int size = ath_rc_priv->rate_table_size;
if ((tx_rate < 0) || (tx_rate > rate_table->rate_cnt))
@@ -1254,7 +1254,7 @@ static void ath_rc_tx_status(struct ath_softc *sc,
u8 flags;
u32 i = 0, rix;
- rate_table = sc->hw_rate_table[sc->sc_curmode];
+ rate_table = sc->cur_rate_table;
/*
* If the first rate is not the final index, there
@@ -1432,6 +1432,7 @@ static void ath_rc_init(struct ath_softc *sc,
ath_rc_priv->max_valid_rate = k;
ath_rc_sort_validrates(rate_table, ath_rc_priv);
ath_rc_priv->rate_max_phy = ath_rc_priv->valid_rate_index[k-4];
+ sc->cur_rate_table = rate_table;
}
/* Rate Control callbacks */
next prev parent reply other threads:[~2008-12-06 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-06 10:34 [ath9k] 2.6.28-rc7-wl Kernel panic when "iwlist ath0 scan" as root Mats Johannesson
2008-12-06 12:45 ` Mats Johannesson
2008-12-06 14:25 ` John W. Linville
2008-12-06 15:13 ` Mats Johannesson
2008-12-06 14:52 ` Sujith [this message]
2008-12-06 17:05 ` Mats Johannesson
2008-12-06 17:52 ` Sujith
2008-12-06 19:22 ` Mats Johannesson
2008-12-07 3:02 ` Sujith
2008-12-07 14:04 ` Mats Johannesson
2008-12-07 15:23 ` Sujith
2008-12-07 16:29 ` Mats Johannesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18746.37273.989918.333164@localhost.localdomain \
--to=m.sujith@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=spamcan1@abrasax.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).