From: Sujith <m.sujith@gmail.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: Patrick McHardy <kaber@trash.net>,
linux-wireless@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
mickflemm@gmail.com, mcgrof@gmail.com
Subject: Re: [RFC]: atk5k: fix FCS corruption for ACKs
Date: Wed, 10 Dec 2008 19:13:34 +0530 [thread overview]
Message-ID: <18751.51078.25636.672867@localhost.localdomain> (raw)
In-Reply-To: <20081210132440.GA12873@hash.localnet>
Bob Copeland wrote:
> 951 /* see if any padding is done by the hw and remove it */
> 952 if (hdrlen & 3) {
> 953 padsize = hdrlen % 4;
> 954 memmove(skb->data + padsize, skb->data, hdrlen);
> 955 skb_pull(skb, padsize);
> 956 }
>
> 957 /* remove FCS before passing up to protocol stack */
> 958 skb_trim(skb, (skb->len - FCS_LEN));
>
I remember removing this piece of code...
Sujith
next prev parent reply other threads:[~2008-12-10 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 5:04 [RFC]: atk5k: fix FCS corruption for ACKs Patrick McHardy
2008-12-10 13:24 ` Bob Copeland
2008-12-10 13:36 ` Johannes Berg
2008-12-10 13:43 ` Sujith [this message]
2008-12-10 14:48 ` Bob Copeland
2008-12-11 19:59 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18751.51078.25636.672867@localhost.localdomain \
--to=m.sujith@gmail.com \
--cc=jirislaby@gmail.com \
--cc=kaber@trash.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).