Re: [PATCH] mac80211: Add 802.11h CSA support

[Sujith <m.sujith@gmail.com>]

Tomas Winkler wrote:
> > +       } else {
> > +               ieee80211_stop_queues_by_reason(&sdata->local->hw,
> > +                                               IEEE80211_QUEUE_STOP_REASON_CSA);
> Why to stop the queues before the switching time
> 

Transmission of frames has to be stopped until the channel is switched.

> > +               ifsta->flags |= IEEE80211_STA_CSA_RECEIVED;
> > +               exp = sw_elem->count * (1024 * bss->beacon_int / 1000 * HZ / 1000);
> > +               mod_timer(&ifsta->chswitch_timer, jiffies + exp);
> What about:
>       mod_timer(&ifsta->chswitch_timer, jiffies +
>         msecs_to_jiffies(sw_elm->count * local->hw.conf.beacon_int));
> 

This is cleaner, I'll add this, thanks.

Sujith