Linux wireless drivers development
 help / color / mirror / Atom feed
From: Sujith <Sujith.Manoharan@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"Guy, Wey-Yi W" <wey-yi.w.guy@intel.com>
Subject: [PATCH] mac80211: fix aggregation for hardware with ampdu queues
Date: Thu, 12 Feb 2009 10:16:02 +0530	[thread overview]
Message-ID: <18835.43402.286764.192456@gargle.gargle.HOWL> (raw)
In-Reply-To: <1234396313.16004.65.camel@johannes.local>

Johannes Berg wrote:
> Hardware with AMPDU queues currently has broken aggregation.
> 
> This patch fixes it by making all A-MPDUs go over the regular AC queues,
> but keeping track of the hardware queues in mac80211. As a first rough
> version, it actually stops the AC queue for extended periods of time,
> which can be removed by adding buffering internal to mac80211, but is
> currently not a huge problem because people rarely use multiple TIDs
> that are in the same AC (and iwlwifi currently doesn't operate as AP).
> 
> This is a short-term fix, my current medium-term plan, which I hope to
> execute soon as well, but am not sure can finish before .30, looks like
> this:
>  1) rework the internal queuing layer in mac80211 that we use for
>     fragments if the driver stopped queue in the middle of a fragmented
>     frame to be able to queue more frames at once (rather than just a
>     single frame with its fragments)
>  2) instead of stopping the entire AC queue, queue up the frames in a
>     per-station/per-TID queue during aggregation session initiation,
>     when the session has come up take all those frames and put them
>     onto the queue from 1)
>  3) push the ampdu queue layer abstraction this patch introduces in
>     mac80211 into the driver, and remove the virtual queue stuff from
>     mac80211 again
> 
> This plan will probably also affect ath9k in that mac80211 queues the
> frames instead of passing them down, even when there are no ampdu queues.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Tested with ath9k, works okay.

Sujith

  reply	other threads:[~2009-02-12  4:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 23:51 [PATCH] mac80211: fix aggregation for hardware with ampdu queues Johannes Berg
2009-02-12  4:46 ` Sujith [this message]
2009-02-12  4:55   ` Guy, Wey-Yi W
2009-02-13  5:04     ` Sujith
2009-02-13  5:11       ` Sujith
2009-02-12  9:08   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18835.43402.286764.192456@gargle.gargle.HOWL \
    --to=sujith.manoharan@atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox