From: Sujith <Sujith.Manoharan@atheros.com>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Handle power modes in isr for power save.
Date: Tue, 3 Mar 2009 15:20:50 +0530 [thread overview]
Message-ID: <18860.64890.657290.185346@gargle.gargle.HOWL> (raw)
In-Reply-To: <8e92b4100903030137r4c412ccdu17020c482d6cb1b3@mail.gmail.com>
Vivek Natarajan wrote:
> SC_OP_WAIT_FOR_BEACON is being changed in rx_tasklet and in isr which
> are mutually exclusive. Even though it might be changed in these two
> regions, it won't affect the ps_wake/ps_restore cycle.
>
> IEEE80211_CONF_PS is changed in siwpower() and also in
> dynamic_ps_work. Even if it is changed while we are executing this
> ps_restore, there won't be any race condition on ps_wake/ps_restore
> cycle and it will work fine.
>
> hw_setpower is just a register write function which may not need a protection(?)
>
> And for the protection of ps_wake/ps_restore itself, there is
> ps_count(atomic) which takes care of properly restoring power save
> state.
>
> Overall, from my perspective there is no need for any more lock.
Sorry, I saw sc_flags and just assumed it would be set from process context.
Thanks for the explanation.
Sujith
prev parent reply other threads:[~2009-03-03 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 14:55 [PATCH] ath9k: Handle power modes in isr for power save Vivek Natarajan
2009-03-02 17:42 ` Sujith
2009-03-03 9:37 ` Vivek Natarajan
2009-03-03 9:50 ` Sujith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18860.64890.657290.185346@gargle.gargle.HOWL \
--to=sujith.manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox