Re: [PATCH] mac80211: Tear down aggregation sessions for suspend/resume

[Sujith <Sujith.Manoharan@atheros.com>]

Johannes Berg wrote:
> > There is a window for a race. Something like this:
> > 
> > From mac80211:
> > 
> > __ieee80211_suspend()
> >      tear_down_BA_sessions(TX, RX)
> >           ampdu_action(STOP)
> >                remove_vifs()
> > 
> > At this point, the driver executes its remove_interface routine.
> > While we are doing this, a TX completion interrupt could be raised,
> > (HW hasn't been stopped yet) and nothing stops the driver from calling
> > ieee80211_start_tx_ba_session().
> > 
> > So the question is: should mac80211 deny ADDBA requests in this case ?
> 
> Interesting observation. We probably should indeed reject that, and also
> if the peer asks for sending aggregation again right away like some
> Broadcom APs will.

Yep, both TX and RX aggregation requests have to be denied.
And this patch would be incomplete without handling this case.
Will send a v2.

Sujith