From: Sujith <Sujith.Manoharan@atheros.com>
To: Luis Rodriguez <lrodriguez@atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Subject: Asus eeepc 1008HA suspend issue and mac80211 suspend corner case
Date: Tue, 22 Dec 2009 10:09:17 +0530 [thread overview]
Message-ID: <19248.19829.293087.367661@gargle.gargle.HOWL> (raw)
In-Reply-To: <20091222022355.GA32508@bombadil.infradead.org>
Luis Rodriguez wrote:
> That log can be found here:
>
> http://bombadil.infradead.org/~mcgrof/logs/2.6.31-with-2.6.32-wireless/irq-disabled.txt
Thanks for the log.
It's a bug in ath9k, related to PowerSave.
Can you test this patch ?
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 3f5b887..419c382 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -2504,6 +2504,9 @@ static void ath9k_stop(struct ieee80211_hw *hw)
return; /* another wiphy still in use */
}
+ /* Ensure HW is awake when we try to shut it down. */
+ ath9k_ps_wakeup(sc);
+
if (ah->btcoex_hw.enabled) {
ath9k_hw_btcoex_disable(ah);
if (ah->btcoex_hw.scheme == ATH_BTCOEX_CFG_3WIRE)
@@ -2524,8 +2527,10 @@ static void ath9k_stop(struct ieee80211_hw *hw)
/* disable HAL and put h/w to sleep */
ath9k_hw_disable(ah);
ath9k_hw_configpcipowersave(ah, 1, 1);
- ath9k_setpower(sc, ATH9K_PM_FULL_SLEEP);
+ ath9k_ps_restore(sc);
+ /* Finally, put the chip in FULL SLEEP mode */
+ ath9k_setpower(sc, ATH9K_PM_FULL_SLEEP);
sc->sc_flags |= SC_OP_INVALID;
mutex_unlock(&sc->mutex);
next prev parent reply other threads:[~2009-12-22 4:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 2:23 Asus eeepc 1008HA suspend issue and mac80211 suspend corner case Luis R. Rodriguez
2009-12-22 4:39 ` Sujith [this message]
2009-12-22 15:50 ` Luis R. Rodriguez
2009-12-22 16:20 ` Luis R. Rodriguez
2009-12-22 16:55 ` Luis R. Rodriguez
2009-12-22 17:59 ` Luis R. Rodriguez
2009-12-23 1:16 ` Luis R. Rodriguez
2009-12-23 2:52 ` Sujith
2009-12-23 2:54 ` Luis R. Rodriguez
2009-12-23 4:06 ` Sujith
2009-12-23 4:00 ` Luis R. Rodriguez
2009-12-23 4:54 ` Sujith
2009-12-23 18:33 ` Luis R. Rodriguez
2009-12-23 19:07 ` Luis R. Rodriguez
2009-12-23 2:29 ` Sujith
2009-12-23 2:40 ` Luis R. Rodriguez
2009-12-23 3:47 ` Sujith
2009-12-23 16:25 ` Luis R. Rodriguez
2009-12-23 2:19 ` Sujith
2009-12-23 2:39 ` Luis R. Rodriguez
2009-12-22 19:12 ` lspci CorrErr- UnsuppReq- changes (was: Asus eeepc 1008HA suspend issue and mac80211 suspend corner) case Luis R. Rodriguez
2009-12-22 19:30 ` mac80211 suspend corner case " Luis R. Rodriguez
2009-12-23 12:08 ` Johannes Berg
2009-12-23 16:28 ` Luis R. Rodriguez
2009-12-23 16:47 ` Johannes Berg
2009-12-23 19:08 ` Luis R. Rodriguez
2009-12-23 19:11 ` Johannes Berg
2009-12-23 19:19 ` Luis R. Rodriguez
2009-12-24 12:43 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19248.19829.293087.367661@gargle.gargle.HOWL \
--to=sujith.manoharan@atheros.com \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).