From: Sujith <Sujith.Manoharan@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: [RFC/RFT] mac80211: allow station add/remove to sleep
Date: Mon, 8 Feb 2010 10:17:50 +0530 [thread overview]
Message-ID: <19311.38774.617169.606262@gargle.gargle.HOWL> (raw)
In-Reply-To: <1265201998.29119.91.camel@johannes.local>
Johannes Berg wrote:
> Many drivers would like to sleep during station
> addition and removal, and currently have a high
> complexity there from not being able to.
>
> This introduces two new callbacks sta_add() and
> sta_remove() that drivers can implement instead
> of using sta_notify() and that can sleep, and
> the new sta_add() callback is also allowed to
> fail.
>
> The reason we didn't do this previously is that
> the IBSS code wants to insert stations from the
> RX path, which is a tasklet, so cannot sleep.
> This patch will keep the station allocation in
> that path, but moves adding the station to the
> driver out of line. Since the addition can now
> fail, we can have IBSS peer structs the driver
> rejected -- in that case we still talk to the
> station but never tell the driver about it in
> the control.sta pointer. If there will ever be
> a driver that has a low limit on the number of
> stations and that cannot talk to any stations
> that are not known to it, we need to do come up
> with a new strategy of handling larger IBSSs,
> maybe quicker expiry or rejecting peers.
Tested in STA mode with ath9k_htc.
Thanks.
Sujith
next prev parent reply other threads:[~2010-02-08 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 12:59 [RFC/RFT] mac80211: allow station add/remove to sleep Johannes Berg
2010-02-08 4:47 ` Sujith [this message]
2010-02-10 5:59 ` Ming Lei
2010-02-10 6:24 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19311.38774.617169.606262@gargle.gargle.HOWL \
--to=sujith.manoharan@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox