From: Sujith <Sujith.Manoharan@atheros.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/5] ath9k_htc: Fix module unloading issue
Date: Wed, 7 Apr 2010 09:54:59 +0530 [thread overview]
Message-ID: <19388.2331.809223.701149@gargle.gargle.HOWL> (raw)
In-Reply-To: <r2id82e647a1004060646ja618eaecye10b08f05d837e2d@mail.gmail.com>
Ming Lei wrote:
> 2010/4/6 Sujith <Sujith.Manoharan@atheros.com>:
> > The maximum number of packets in a single buffer in
> > stream mode is 10. The driver currently uses 8 - which
> > caused stack corruption, in the absence of any kind
> > of OOB checking.
> >
> > Fixing this to the correct value of 10 fixes the module
> > unload issue.
>
> Great, the patch fixes the issue of destruction of urb->use_count,
> which caused to sleep forever of usb_kill_urb().
>
> For this kind of dark issue, it is better to add check for 'pool_index'.
Right, it will be done in a separate patch.
> Tested-by: Ming Lei <tom.leiming@gmail.com>
Thanks !
Sujith
prev parent reply other threads:[~2010-04-07 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 9:58 [PATCH 3/5] ath9k_htc: Fix module unloading issue Sujith
2010-04-06 13:46 ` Ming Lei
2010-04-07 4:24 ` Sujith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19388.2331.809223.701149@gargle.gargle.HOWL \
--to=sujith.manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox