From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
ath10k@lists.infradead.org, akolli@qti.qualcomm.com,
linux-wireless@vger.kernel.org
Subject: Re: ath10k: Fix reported HT MCS rates with NSS > 1
Date: Mon, 06 Nov 2017 10:02:00 +0100 [thread overview]
Message-ID: <1960925.hkIbv4gX65@bentobox> (raw)
In-Reply-To: <d27a10b1-6323-ebf0-5c2d-4a9c3b8d978d@dd-wrt.com>
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
On Montag, 6. November 2017 09:28:42 CET Sebastian Gottschall wrote:
> Am 06.11.2017 um 09:23 schrieb Sven Eckelmann:
> > On Sonntag, 5. November 2017 10:22:22 CET Sebastian Gottschall wrote:
> >> the assumption made in this patch is obviously wrong (at least for more
> >> recent firmwares and 9984)
> >> my log is flooded with messages like
> >> [208802.803537] ath10k_pci 0001:03:00.0: Invalid VHT mcs 15 peer stats
> >> [208805.108515] ath10k_pci 0001:03:00.0: Invalid VHT mcs 15 peer stats
> >> [208821.747621] ath10k_pci 0001:03:00.0: Invalid VHT mcs 15 peer stats
> >> [208822.516599] ath10k_pci 0001:03:00.0: Invalid VHT mcs 15 peer stats
> >> [208841.257780] ath10k_pci 0001:03:00.0: Invalid VHT mcs 15 peer stats
[...]
> > This patch only splits WMI_RATE_PREAMBLE_HT & WMI_RATE_PREAMBLE_VHT. And for
> > WMI_RATE_PREAMBLE_HT (*not VHT*), it uses a slightly different approach. But
> > the WMI_RATE_PREAMBLE_VHT part (which you see in your logs) is basically
> > untouched.
>
> then a question follows up. is this check really neccessary?
Until we find out what the heck VHT MCS 15 should mean in this context - maybe.
But to the message - no, the message is most likely not necessary for each
received "invalid" peer tx stat.
Kind regards.
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-06 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 9:09 [PATCH] ath10k: Fix reported HT MCS rates with NSS > 1 Sven Eckelmann
2017-05-11 9:39 ` Arend Van Spriel
2017-05-11 10:08 ` Sven Eckelmann
2017-05-23 15:28 ` Kalle Valo
2017-11-05 9:22 ` Sebastian Gottschall
2017-11-06 8:23 ` Sven Eckelmann
2017-11-06 8:28 ` Sebastian Gottschall
2017-11-06 9:02 ` Sven Eckelmann [this message]
2017-11-06 21:25 ` Peter Oh
2017-11-20 12:10 ` Kalle Valo
2017-11-21 6:13 ` akolli
2017-12-05 9:16 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1960925.hkIbv4gX65@bentobox \
--to=sven.eckelmann@openmesh.com \
--cc=akolli@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).