From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3376221F0F for ; Fri, 11 Apr 2025 17:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744391108; cv=none; b=vFlyNONgIx8MgfiELHfcR4sL2DBaLucHsUAmkR4VnyTO+bnSp9+dHB46+SHXRsjRN7mKvyQI1Jof7WStjbcl9RhqxrN2c2DBFi/lIqHxSrtY+99lUI3SastMvQQYyQ8wyXchrb4CTVE+xKcSpgU47jwoDY49u2fTO1OBa0QOegc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744391108; c=relaxed/simple; bh=Zs24uJAaPNdL7CMzi1gfleFstPNRatFfxR2lJdWyGy0=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=D0gyhFxJpb4CMWw5HPmPe6Qw5DcBgFs33IYFR2cYTutjpzfj8Dhlo+5T4AhqHcGXZ/TLMbkzfAyvl9gUh3YAzfap0i9kp7h0Mhu2DAFHY16u1sipDOxuL8EDRznPLDLRAtsU0M0NTFRiQOqg+LOKPEtO9hLO0w47CnrIICdAamQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=XvJet4ta; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XvJet4ta" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-afc857702d1so2100384a12.3 for ; Fri, 11 Apr 2025 10:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1744391106; x=1744995906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=Zs24uJAaPNdL7CMzi1gfleFstPNRatFfxR2lJdWyGy0=; b=XvJet4ta3eOAGfjticpH7ME4nff2cHJhtanIpB14HhW8IVhET2Y1kRk0kqzRmPh/BM blSgj6Ffn8llUOpzv31KfC7s2UtlOobR4Udy1S05gKBDD7S+r1wt8PwfFvVr0HyyoWUQ H1ur6WZhKsvsVyDP9bbHVUq1VUcqBAcWW7lcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744391106; x=1744995906; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zs24uJAaPNdL7CMzi1gfleFstPNRatFfxR2lJdWyGy0=; b=aUhx9rgHDuiMP23AFlyROf5GBGB3jtqa9RDrckgYPQfkTfzUdMRJjPDyifPk3Ht6Vh bDw9bhd9FQ8yRV/v4/T4JONpIdGFUKdi/iMxS/w2EqrwWvjoADmTxqv4MORuHN6+OKx1 zblFTiMKVdis9Yt6NkkV1FJ9CwKADPm+RNRU1LVMunfPAmnH87ZhYV1Q2oknFEmg+HI7 2BCD1PvB9h6/cuL0qbDWpEyH5AIZikT2aeFIkgjoDqKCKTqL8GFnsMYuWRetesPeOb+N Amipv/jXlLsy2pzO50/GQ+ASZTqU22jJLRM40pU/OEx+SpTXYHvqIoR9VZ14hrXmfQCb SqZg== X-Forwarded-Encrypted: i=1; AJvYcCVC0d9nrs9tQAOcq1BVLSoXeugNIqjDM24jnXiaFVJ2jSWU6amzJkBPW3qOMcZLqTkqVzTmOqZDC9hfM/uUXA==@vger.kernel.org X-Gm-Message-State: AOJu0YxTYtjJY4jPJCtRYO7VqVyeF0TeuXp5unGQG8C1VH+iFGR7HTnG XRD9x3si3UgUksSG60DNdAXSjSUvq+QNS93RKYX8o6NTmyQKbeyFsHFV3TpdLg== X-Gm-Gg: ASbGnctO8a2N7SLP4VFx62OE05szXnaIDd+tD1NSJZKbtiq53gv1G+fnHqc20C5Ny59 zFbGnz6NSKR/ammNTKRIHb7Rs75FTb1pMtd+1ZvIqHiHon2cGBGWD+S1o1dLm0TZeouBlg27pgN JTRdU09OHEPoWmNEvniIs7Tfq5tqf6LLa4lXd/TM9gjXJqH2vYCiAQuQl+37ufaJBW0WHx0Dpn1 kVU2nmfsVmYQ05V0Z16UquMChXguBc94gPyCCQBjYJ7Ii7n3g/rwRbwN0lW1Ut2SwrhO7R0nGFY bKaS63YGFPhYX7fSAJYMsaRdvGBSDkAIBb9sN8PeN9kIGUqPzZEFdBsIYrd/AV+8TO3wGe5CC1Q OzlE= X-Google-Smtp-Source: AGHT+IFsxw8IYiWvCcCfohL9OR/GeWdiXtYFPHAC7JyqV95Ksyc9aMccKi6WlaMRFkxD3Uw+BXU/BA== X-Received: by 2002:a17:902:e5cf:b0:215:94eb:adb6 with SMTP id d9443c01a7336-22bea4efe58mr64393975ad.40.1744391105389; Fri, 11 Apr 2025 10:05:05 -0700 (PDT) Received: from [192.168.178.39] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7c93aa3sm52081595ad.149.2025.04.11.10.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 10:05:04 -0700 (PDT) From: Arend Van Spriel To: "Kuan-Wei Chiu" CC: Johannes Berg , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Yu-Chun Lin Date: Fri, 11 Apr 2025 19:04:43 +0200 Message-ID: <19625cf93f8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20250409154356.423512-1-visitorckw@gmail.com> <20250409154356.423512-4-visitorckw@gmail.com> <25b7888d-f704-493b-a2d7-c5e8fff9cfb4@broadcom.com> <740c7de894d39249665c6333aa3175762cfb13c6.camel@sipsolutions.net> <1961e19ee10.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> User-Agent: AquaMail/1.54.1 (build: 105401536) Subject: Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd() Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On April 11, 2025 6:37:35 PM Kuan-Wei Chiu wrote: > On Thu, Apr 10, 2025 at 07:08:58AM +0200, Arend Van Spriel wrote: >> On April 10, 2025 12:06:52 AM Johannes Berg wrote: >> >>> On Wed, 2025-04-09 at 20:43 +0200, Arend van Spriel wrote: >>>> >>>> This is orthogonal to the change to parity_odd() though. More specific >>>> to the new parity_odd() you can now do following as parity_odd() >>>> argument is u64: >>>> >>>> err = !parity_odd(*(u16 *)p); >>> >>> Can it though? Need to be careful with alignment with that, I'd think. >> >> My bad. You are absolutely right. > Then maybe we can still go with: > > err = !parity_odd(p[0] ^ p[1]); > > I believe this should still be a fairly safe approach? Yes. Or whatever the name will be ;-) Regards, Arend