Linux wireless drivers development
 help / color / mirror / Atom feed
From: Sujith <m.sujith@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Sujith <m.sujith@gmail.com>,
	Jouni.Malinen@atheros.com,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] cfg80211: Add HT BSS attributes
Date: Wed, 5 Jan 2011 21:50:11 +0530	[thread overview]
Message-ID: <19748.39483.90936.674269@gargle.gargle.HOWL> (raw)
In-Reply-To: <1294243338.3590.11.camel@jlt3.sipsolutions.net>

Johannes Berg wrote:
> On Wed, 2011-01-05 at 21:17 +0530, Sujith wrote:
> > From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> > 
> > Add two new per-BSS attributes to allow configuration of
> > HT capabilites and operational parameters by hostapd.
> 
> Looks fine, but
> 
> > @@ -2597,6 +2597,12 @@ static int nl80211_set_bss(struct sk_buff *skb, struct genl_info *info)
> >  	if (info->attrs[NL80211_ATTR_BSS_HT_OPMODE])
> >  		params.ht_opmode =
> >  			nla_get_u16(info->attrs[NL80211_ATTR_BSS_HT_OPMODE]);
> > +	if (info->attrs[NL80211_ATTR_BSS_HT_CAPAB])
> > +		params.ht_capab =
> > +			nla_get_u16(info->attrs[NL80211_ATTR_BSS_HT_CAPAB]);
> > +	if (info->attrs[NL80211_ATTR_BSS_HT_PARAM])
> > +		params.ht_param =
> > +			nla_get_u8(info->attrs[NL80211_ATTR_BSS_HT_PARAM]);
> >  
> >  	if (!rdev->ops->change_bss)
> >  		return -EOPNOTSUPP;
> 
> This appears to be missing a -1 initialisation?

Will fix.

Sujith

  reply	other threads:[~2011-01-05 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-05 15:47 [RFC] cfg80211: Add HT BSS attributes Sujith
2011-01-05 16:02 ` Johannes Berg
2011-01-05 16:20   ` Sujith [this message]
2011-01-05 16:03 ` Johannes Berg
2011-01-05 16:22   ` Sujith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19748.39483.90936.674269@gargle.gargle.HOWL \
    --to=m.sujith@gmail.com \
    --cc=Jouni.Malinen@atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox