From: Sujith <m.sujith@gmail.com>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: [PATCH] ath9k_htc: abort tx/rx on fast channel change
Date: Sun, 16 Jan 2011 16:50:03 +0530 [thread overview]
Message-ID: <19762.54371.65123.60502@gargle.gargle.HOWL> (raw)
In-Reply-To: <1295158794-3088-1-git-send-email-rmanoharan@atheros.com>
Rajkumar Manoharan wrote:
> - if (!fastcc)
> + if (fastcc) {
> + /* abort pending tx frames */
> + WMI_CMD(WMI_ABORT_TX_DMA_CMDID);
Why abort instead of stop ?
And if i remember correctly, aborting of TX is enabled
only for the AR9003 family.
> + WMI_CMD(WMI_ABORT_TXQ_CMDID);
This is exactly the same as DRAIN_TXQ_ALL.
> + /* Clear receive filter */
> + ath9k_hw_setrxfilter(ah, 0);
Why should the filter be cleared ?
> + WMI_CMD(WMI_STOP_DMA_RECV_CMDID);
WMI_STOP_RECV does this already.
> + WMI_CMD(WMI_RX_LINK_CMDID);
The host should have nothing to do with setting the rx_link
variable on the target. This WMI command should really be
removed.
A little more information on what this patch fixes would be nice.
Sujith
prev parent reply other threads:[~2011-01-16 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 6:19 [PATCH] ath9k_htc: abort tx/rx on fast channel change Rajkumar Manoharan
2011-01-16 11:20 ` Sujith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19762.54371.65123.60502@gargle.gargle.HOWL \
--to=m.sujith@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox