Re: [RFC/WIP 30/33] ath9k_htc: Fix host RX initialization

[Sujith <m.sujith@gmail.com>]

Vasanthakumar Thiagarajan wrote:
> I think we need to take care a bug in reg AR_STA_ID1 configuration.
> During hw reset, operating mode is set in AR_STA_ID1 but right after
> it's overwritten. See the following code segment in
> ath9k_hw_reset().
> 
>  ath9k_hw_set_operating_mode(ah, ah->opmode);
> 
>  ENABLE_REGWRITE_BUFFER(ah);
> 
>  REG_WRITE(ah, AR_STA_ID0, get_unaligned_le32(common->macaddr));
>  REG_WRITE(ah, AR_STA_ID1, get_unaligned_le16(common->macaddr + 4)
>                   | macStaId1
>                   | AR_STA_ID1_RTS_USE_DEF
>                   | (ah->config.
>                      ack_6mb ? AR_STA_ID1_ACKCTS_6MB : 0)
>                   | ah->sta_id1_defaults);
> 
> 
> Existing code works because we configure the opmode again through
> ath9k_htc_opmode_init() after reset. 

Looks like I changed this, see commit 6819d57f07440a8f9540967d9212a70e9c98eceb
But yes, opmode_init() in both ath9k and ath9k_htc takes care of this.
I'll fix this.

Sujith