Linux wireless drivers development
 help / color / mirror / Atom feed
From: Sujith <m.sujith@gmail.com>
To: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 16/23] ath9k_htc: Disable powersave if an AP interface is present
Date: Mon, 21 Feb 2011 13:12:43 +0530	[thread overview]
Message-ID: <19810.6003.617296.993948@gargle.gargle.HOWL> (raw)
In-Reply-To: <20110221051715.GA17236@vasanth-laptop>

Vasanthakumar Thiagarajan wrote:
> On Mon, Feb 21, 2011 at 07:49:46AM +0530, Sujith wrote:
> > From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> > 
> > Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> > ---
> >  drivers/net/wireless/ath/ath9k/htc_drv_main.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> > index f384b35..4779bb1 100644
> > --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> > @@ -1393,7 +1393,8 @@ static int ath9k_htc_config(struct ieee80211_hw *hw, u32 changed)
> >  
> >  	}
> >  
> > -	if (changed & IEEE80211_CONF_CHANGE_PS) {
> > +	if ((priv->ah->opmode != NL80211_IFTYPE_AP) &&
> > +	    (changed & IEEE80211_CONF_CHANGE_PS)) {
> >  		if (conf->flags & IEEE80211_CONF_PS) {
> >  			ath9k_htc_setpower(priv, ATH9K_PM_NETWORK_SLEEP);
> >  			priv->ps_enabled = true;
> 
> Is it not that mac80211 already takes care of that?.

Yeah, it appears to have been fixed recently in mac80211.
So this patch can be dropped.

Sujith

      reply	other threads:[~2011-02-21  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21  2:19 [PATCH 16/23] ath9k_htc: Disable powersave if an AP interface is present Sujith
2011-02-21  5:17 ` Vasanthakumar Thiagarajan
2011-02-21  7:42   ` Sujith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19810.6003.617296.993948@gargle.gargle.HOWL \
    --to=m.sujith@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=vasanth@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox