From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3218C742B2 for ; Fri, 12 Jul 2019 10:39:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C86C3208E4 for ; Fri, 12 Jul 2019 10:39:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b="fZ/wiGDd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726576AbfGLKjD (ORCPT ); Fri, 12 Jul 2019 06:39:03 -0400 Received: from dvalin.narfation.org ([213.160.73.56]:45846 "EHLO dvalin.narfation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfGLKjD (ORCPT ); Fri, 12 Jul 2019 06:39:03 -0400 Received: from bentobox.localnet (p5B34C47F.dip0.t-ipconnect.de [91.52.196.127]) by dvalin.narfation.org (Postfix) with ESMTPSA id A2FD62013F; Fri, 12 Jul 2019 10:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1562927939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M76eFx/GbGOggAGWaIqi4k4J/uvPn9b2XyNJHWx9nYs=; b=fZ/wiGDdh4FiSHkKl+tn3IOo3P/oci2phukhdQk9rkirYVd71LTc0zEQBuMtH5SBLDXKxW CJu/COj5fY+15dIbo5SsuC83lv/jmId01EQMVXjNrC3Zu0WfSctCoINrvlVjDXPccumsdF v6EoQsF6uwkEj2uciO4dX8KYkE4kPwg= From: Sven Eckelmann To: Johannes Berg Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, hostap@lists.infradead.org Subject: Re: [PATCH v3 0/3] mac80211/ath11k: HE mesh support Date: Fri, 12 Jul 2019 12:38:54 +0200 Message-ID: <1999032.fCPl2VLiSg@bentobox> In-Reply-To: <9a1d7a6651d3bf6c4a43c5bc8659df690c009328.camel@sipsolutions.net> References: <20190612193510.29489-1-sven@narfation.org> <2019422.XptUlqRJNA@bentobox> <9a1d7a6651d3bf6c4a43c5bc8659df690c009328.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2301428.JFisq3Yxm6"; micalg="pgp-sha512"; protocol="application/pgp-signature" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1562927939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M76eFx/GbGOggAGWaIqi4k4J/uvPn9b2XyNJHWx9nYs=; b=v7IbNUSkkKeX8yE0YqGA4/6uK9Mmm0jwTFCMg8+Jlw4ChDr7wYuKYkUfeIaC0Sm18z0NpE TIMMTGY+GTgjKR0rlwl9gQgKJ5NZ2cCsCUUGbj97TWwwm5iKeZDzkBA+m2zBHCoEXgB5Gt jY2Yt19om2ZtiwiSVaxVkEJYOrSg4EU= ARC-Seal: i=1; s=20121; d=narfation.org; t=1562927939; a=rsa-sha256; cv=none; b=OXkUbNX9bgzh4bFn+UsdPZNqS34xo6BvM5jR/xiSoEIfBsloSzxOVuHALahG+DMkbqCMXb 9+k0QyFjnltKpjY737qJ4H18yd5uf3pqizVvMeOU9Z4/wCghXOZ7IKKmRHj8fPAOtgTueV w5q+a51YVrcxNUbxp432jLEv27XFq9o= ARC-Authentication-Results: i=1; dvalin.narfation.org; auth=pass smtp.auth=sven smtp.mailfrom=sven@narfation.org Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --nextPart2301428.JFisq3Yxm6 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, 12 July 2019 11:42:51 CEST Johannes Berg wrote: > On Fri, 2019-07-12 at 11:36 +0200, Sven Eckelmann wrote: > > > > There is already a workaround for that in the hostap testcases: > > > > if all_cap_one: > > # It looks like tshark parser was broken at some point for > > # wlan.mesh.config.cap which is now (tshark 2.6.3) pointing to incorrect > > # field (same as wlan.mesh.config.ps_protocol). This used to work with > > # tshark 2.2.6. > > # > > # For now, assume the capability field ends up being the last octet of > > # the frame. > > > But maybe you already spotted the problem - it requires that mesh > > configuration element is the last element. Which is not the case here - > > similar to 5GHz tests (where you have most likely a VHT cap/oper element > > after the meshconf_ie). > > > > I hope that this makes more sense now. > > Ah, yes, it does. So I guess we need to update/fix that workaround. I will prepare a patch now for hostap after lunch. > And > I guess newer tshark (which you used) is fixed again, if I understand > correctly? Yes and no, the master branch is fixed. But unfortunately, there is no release with this fix. And the problems is there since commit 3c427376579a ("802.11: Use proto_tree_add_bitmask") and release v2.4.0rc0. But unfortunately, the workaround was added with commit 2cbaf0de223b ("tests: Work around tshark bug in wpas_mesh_max_peering") instead of bringing a fix upstream. Kind regards, Sven --nextPart2301428.JFisq3Yxm6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAl0oYz4ACgkQXYcKB8Em e0Z41A/8DPolUsKnKtf/r6TUzj7Z0z50iFBWT00vfBPcz0TapYwyJgqGBWjyjAaN UVZGfFAX/QTgKJxYobt8KSJLkclgobdTy87zQqOwwgWW20dZdHOJ4Qqj+nd3bKQ8 q2a1YZKcPsal2LYB/Ca+0gX/ndm5oMaDZbGZObpi/nKrbFNW+7g7IV+8Kfl9Uxr6 s3S2Pl76M5cyK6DkA9r1YEM3YauT5eHf1jCK1yhOVEb1kHGDkgOZruRbIBRuTJTv wft/AuZkxgTpgCcDp2WPbdDGwj/17aH60BOlsLo802Gt0bAdzH/rSSMdkHjJC+1R BupOHt6GU4wWLz51pqAO+7/SwfmCRue+T7BWdzKRXWklcjtdn7mHmUPvgoJb8wOO MqL/+NjP4mfEyvRyikoSrYVgbDLp/ZCQDfYSFaDzdjjrepqp5LLE03Dk7vFz2/8X mhfAl0GHJR6pxvGo0AxA+mF/l8JSYzjNS7QChhFEDr6bZiZvMyngrYLaonkffTb2 lpQrQJSRiGhxAKQFHvLwW87wrVyt9tzwt5NVeDg8JTLUF14HZ/iI+3NuzQ3V2ggr hixI5YmSNSLG20CCgfJ8UDOyU1/RhTCqep1iitKw94CTzkmCs67LbjHOyevH6pn8 J6kK30VPMCVix5CSJCC0QMnwOXP7Z4BblReYeyn/+FAgFBYUMzw= =N9dx -----END PGP SIGNATURE----- --nextPart2301428.JFisq3Yxm6--