Re: [PATCH v2 00/22] add support for S1G association

Thomas Pedersen
2020-09-08T18:30:45Z

On 2020-09-06 09:04, Johannes Berg wrote:
> On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:
>>
>> Note the mac80211_hwsim S1G support introduces a regression in a few
>> hostap hwsim tests. This is because when processing the reported
>> bands,
>> hostap assumes freq < 4000 is 11b, and the actual 11b/g band is
>> overwritten by the S1G band info. Though it does count as a userspace
>> regression, I'm not sure there is much to do about it besides apply a
>> small patch to hostapd which treats freq < 2000 as an unknown band.
>>
>> After the hostap workaround
>> (https://lists.infradead.org/pipermail/hostap/2020-August/038748.html),
>> these patches continue to pass the hwsim tests as well as HEAD.
>
>
> That sounds like we could "hack around" it by sending the S1G data
> first, and then the 2.4 GHz, so the latter overwrites it on broken
> versions?

Yes that could work.

> Not sure it's worth it though, I'd say it depends a bit on what real
> hardware plans are?
>
> I mean, if it's only hwsim for now ... who cares? And if it's going to
> be special hardware that only does S1G, then also meh, you need newer
> versions to support it, big deal.

AFAIK there are no multi-band S1G chips. The initial focus (from WFA)
seems
to be industrial IOT.

> But if OTOH a commonly used chipset like e.g. ath9k or ath10k will get
> S1G support, then that'd be more relevant?

--
thomas