From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
Subject: Re: [PATCH] wifi: mt76: mt7925: remove code guarded by nonexistent config option
Date: Wed, 10 Jun 2026 16:35:36 +0200 [thread overview]
Message-ID: <19a4d71b-cfcc-49c9-a564-5795a0b7a0cc@gmail.com> (raw)
In-Reply-To: <20260610042429.222717-1-enelsonmoore@gmail.com>
On 10/06/2026 06:24, Ethan Nelson-Moore wrote:
> A small piece of code in mt7925/regs.h depends on CONFIG_MT76_DEV, which
> has never been defined in the kernel. Remove this dead code.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7925/regs.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/regs.h b/drivers/net/wireless/mediatek/mt76/mt7925/regs.h
> index 24985bba1b90..ea04e477a67c 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/regs.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/regs.h
> @@ -74,11 +74,7 @@
> #define MT_HIF_REMAP_BASE_L1 0x130000
>
> #define MT_HIF_REMAP_L2 0x0120
> -#if IS_ENABLED(CONFIG_MT76_DEV)
> -#define MT_HIF_REMAP_BASE_L2 (0x7c500000 - (0x7c000000 - 0x18000000))
> -#else
> #define MT_HIF_REMAP_BASE_L2 0x18500000
> -#endif
>
> #define MT_WFSYS_SW_RST_B 0x7c000140
>
prev parent reply other threads:[~2026-06-10 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 4:24 [PATCH] wifi: mt76: mt7925: remove code guarded by nonexistent config option Ethan Nelson-Moore
2026-06-10 14:35 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19a4d71b-cfcc-49c9-a564-5795a0b7a0cc@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=enelsonmoore@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=mingyen.hsieh@mediatek.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox