From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH rtw-next v2 01/11] wifi: rtw89: Fix rtw89_core_get_ch_dma() for RTL8852CU
Date: Tue, 26 Aug 2025 19:38:35 +0300 [thread overview]
Message-ID: <19e4debd-589c-43b6-95ac-1b6e94ad8c90@gmail.com> (raw)
In-Reply-To: <3ae0e8e7efbc4b6189ce9416c3a890eb@realtek.com>
On 26/08/2025 12:00, Ping-Ke Shih wrote:
>>>
>>> +static inline
>>> +u8 rtw89_chip_get_ch_dma(struct rtw89_dev *rtwdev, u8 qsel)
>>> +{
>>> + const struct rtw89_chip_info *chip = rtwdev->chip;
>>> +
>>> + return chip->ops->get_ch_dma(rtwdev, qsel);
>>> +}
>>> +
>>> static inline
>>> void rtw89_chip_mac_cfg_gnt(struct rtw89_dev *rtwdev,
>>> const struct rtw89_mac_ax_coex_gnt *gnt_cfg)
>>>
>>> Also the rtw89_core_get_ch_dma() is moved to core.c, and add
>>> rtw89_core_get_ch_dma_v1() for RTL8922DE.
>>>
>>> However, USB can use different mapping rule, so we should extend the size
>>> to RTW89_HCI_TYPE_NUM. Then,
>>>
>>> return chip->ops->get_ch_dma[rtwdev->hci.type](rtwdev, qsel);
>>>
>>> If you want my patch as first patch of this patchset, I can share it as RFC.
>>>
>>
>> Yes, that would be good.
>
> Finally, I decide to send a formal patch within patchset for coming WiFi 7 chip.
> "[PATCH rtw-next 09/10] wifi: rtw89: abstract getting function of DMA channel"
>
> [1] https://lore.kernel.org/linux-wireless/20250826085339.28512-1-pkshih@realtek.com/T/#u
>
>
That's great, I will prepare v3 then.
next prev parent reply other threads:[~2025-08-26 16:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 20:49 [PATCH rtw-next v2 00/11] wifi: rtw89: Add support for RTL8852CU Bitterblue Smith
2025-08-01 20:51 ` [PATCH rtw-next v2 01/11] wifi: rtw89: Fix rtw89_core_get_ch_dma() " Bitterblue Smith
2025-08-04 18:44 ` Bitterblue Smith
2025-08-05 0:40 ` Ping-Ke Shih
2025-08-10 21:37 ` Bitterblue Smith
2025-08-26 9:00 ` Ping-Ke Shih
2025-08-26 16:38 ` Bitterblue Smith [this message]
2025-08-01 20:52 ` [PATCH rtw-next v2 02/11] wifi: rtw89: usb: Fix rtw89_usb_get_bulkout_id() " Bitterblue Smith
2025-08-08 5:54 ` Ping-Ke Shih
2025-08-10 21:58 ` Bitterblue Smith
2025-08-01 20:53 ` [PATCH rtw-next v2 03/11] wifi: rtw89: usb: Fix rtw89_usb_ops_mac_pre_init() " Bitterblue Smith
2025-08-08 6:00 ` Ping-Ke Shih
2025-08-01 20:53 ` [PATCH rtw-next v2 04/11] wifi: rtw89: usb: Fix rtw89_usb_ops_mac_post_init() " Bitterblue Smith
2025-08-08 6:02 ` Ping-Ke Shih
2025-08-01 20:54 ` [PATCH rtw-next v2 05/11] wifi: rtw89: Fix rtw89_mac_dmac_func_pre_en_ax() for USB/SDIO Bitterblue Smith
2025-08-08 6:03 ` Ping-Ke Shih
2025-08-01 20:54 ` [PATCH rtw-next v2 06/11] wifi: rtw89: 8852c: Fix rtw8852c_pwr_{on,off}_func() for USB Bitterblue Smith
2025-08-08 6:04 ` Ping-Ke Shih
2025-08-01 21:03 ` [PATCH rtw-next v2 07/11] wifi: rtw89: Add rtw8852c_dle_mem_usb{2,3} Bitterblue Smith
2025-08-08 6:05 ` Ping-Ke Shih
2025-08-01 21:03 ` [PATCH rtw-next v2 08/11] wifi: rtw89: Add rtw8852c_hfc_param_ini_usb Bitterblue Smith
2025-08-08 6:07 ` Ping-Ke Shih
2025-08-01 21:04 ` [PATCH rtw-next v2 09/11] wifi: rtw89: 8852c: Accept USB devices and load their MAC address Bitterblue Smith
2025-08-08 6:11 ` Ping-Ke Shih
2025-08-01 21:06 ` [PATCH rtw-next v2 10/11] wifi: rtw89: Add rtw8852cu.c Bitterblue Smith
2025-08-08 6:13 ` Ping-Ke Shih
2025-08-01 21:07 ` [PATCH rtw-next v2 11/11] wifi: rtw89: Enable the new rtw89_8852cu module Bitterblue Smith
2025-08-08 6:13 ` Ping-Ke Shih
2025-08-01 23:08 ` rtw89: RTL8832CU loses the connection Bitterblue Smith
2025-08-08 6:21 ` Ping-Ke Shih
2025-08-10 22:06 ` Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e4debd-589c-43b6-95ac-1b6e94ad8c90@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).