From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtlwifi: pci: Fix condition to wake the queues
Date: Wed, 19 Feb 2025 06:20:51 +0000 [thread overview]
Message-ID: <1a11b3b765404ab0b64b0e0614e44ac9@realtek.com> (raw)
In-Reply-To: <0c91ac77-a652-4ab4-b911-e0a2386fb863@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> The TX queues should be woken when there are at least 4 available
> entries, not when there are at most 4.
>
> Tested with RTL8821AE.
>
> Fixes: d0311314d002 ("rtlwifi: rtl8192ee: Fix handling of new style descriptors")
I agree your change looks more reasonable. Did you really meet the case
and this patch solves it?
By the changes of d0311314d002, I can't really understand why the initial
version and the commit do. Considering the commit "fix" some situations,
I don't know if this patch would break them again. Could you look into
rtlwifi PCI flow deeper and share your ideas?
next prev parent reply other threads:[~2025-02-19 6:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 21:42 [PATCH] wifi: rtlwifi: pci: Fix condition to wake the queues Bitterblue Smith
2025-02-19 6:20 ` Ping-Ke Shih [this message]
2025-02-26 22:50 ` Bitterblue Smith
2025-02-27 0:49 ` Ping-Ke Shih
2025-02-26 1:47 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a11b3b765404ab0b64b0e0614e44ac9@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox