Re: [PATCH 5/7] wil6210: add support for enhanced DMA RX data flows

[merez@codeaurora.org]

On 2018-05-25 15:31, Kalle Valo wrote:
> Maya Erez <merez@codeaurora.org> writes:
> 
>> From: Gidon Studinski <gidons@codeaurora.org>
>> 
>> Enhanced DMA RX data path is handled using a single
>> RX descriptor ring for all VIFs.
>> Multiple RX status rings are supported, to allow RSS
>> and multi MSI support.
>> The driver gets the RX completions via the RX status rings.
>> The RX status message includes the completed RX buffer ID,
>> which points to the allocated SKB.
>> 
>> The enhanced DMA RX data flow supports RX chaining, where
>> multiple SKBs are merged into a single packet.
>> 
>> Enhanced DMA HW supports RX HW reorder offload, enabled by
>> default and can be disabled via module parameter.
>> 
>> Signed-off-by: Gidon Studinski <gidons@codeaurora.org>
>> Signed-off-by: Maya Erez <merez@codeaurora.org>
> 
> kbuild bot reported a warning but not sure if it's valid, please take a
> look:
> 
>    drivers/net/wireless/ath/wil6210/txrx_edma.c: In function
>    'wil_rx_handle_edma':
>>> drivers/net/wireless/ath/wil6210/txrx_edma.c:815:7: warning: 'stats'
>    may be used uninitialized in this function [-Wmaybe-uninitialized]
>      stats->rx_non_data_frame++;
>      ~~~~~^~~~~~~~~~~~~~~~~~~
>    drivers/net/wireless/ath/wil6210/txrx_edma.c:908:24: note: 'stats'
>    was declared here
>      struct wil_net_stats *stats;
>                            ^~~~~

This is false alarm but looking again on the code I think it is better 
to initialize stats.
I'll upload a fix.

-- 
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project