From: Ping-Ke Shih <pkshih@realtek.com>
To: Nithyanantham Paramasivam
<nithyanantham.paramasivam@oss.qualcomm.com>,
"ath12k@lists.infradead.org" <ath12k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH ath-next v2 2/3] wifi: ath12k: Fix TX status reporting to mac80211 when offload is enabled
Date: Fri, 18 Jul 2025 09:12:53 +0000 [thread overview]
Message-ID: <1ae4000edd954cf492e95bdb059c89b2@realtek.com> (raw)
In-Reply-To: <20250718025513.32982-3-nithyanantham.paramasivam@oss.qualcomm.com>
> @@ -578,6 +579,8 @@ ath12k_dp_tx_htt_tx_complete_buf(struct ath12k_base *ab,
> struct ath12k *ar;
> struct sk_buff *msdu = desc_params->skb;
> s32 noise_floor;
> + struct ieee80211_tx_status status = { 0 };
With '= {}', no matter how the struct changes, you don't need to change the
code accordingly.
> + struct ath12k_peer *peer;
>
> skb_cb = ATH12K_SKB_CB(msdu);
> info = IEEE80211_SKB_CB(msdu);
[...]
> @@ -805,6 +830,12 @@ static void ath12k_dp_tx_complete_msdu(struct ath12k *ar,
> struct ath12k_vif *ahvif;
> struct sk_buff *msdu = desc_params->skb;
> s32 noise_floor;
> + struct ieee80211_tx_status status = { 0 };
> + struct ieee80211_rate_status status_rate = { 0 };
ditto.
> + struct ath12k_peer *peer;
> + struct ath12k_link_sta *arsta;
> + struct ath12k_sta *ahsta;
> + struct rate_info rate;
>
> if (WARN_ON_ONCE(ts->buf_rel_source != HAL_WBM_REL_SRC_MODULE_TQM)) {
> /* Must not happen */
next prev parent reply other threads:[~2025-07-18 9:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 2:55 [PATCH ath-next v2 0/3] wifi: ath12k: Add 802.11 encap/decap offload support Nithyanantham Paramasivam
2025-07-18 2:55 ` [PATCH ath-next v2 1/3] wifi: ath12k: Fix the handling of TX packets in Ethernet mode Nithyanantham Paramasivam
2025-07-18 17:16 ` Jeff Johnson
2025-07-18 2:55 ` [PATCH ath-next v2 2/3] wifi: ath12k: Fix TX status reporting to mac80211 when offload is enabled Nithyanantham Paramasivam
2025-07-18 9:12 ` Ping-Ke Shih [this message]
2025-07-18 12:56 ` Nithyanantham Paramasivam
2025-07-18 13:28 ` Ping-Ke Shih
2025-07-18 13:47 ` Nithyanantham Paramasivam
2025-07-18 13:55 ` Jeff Johnson
2025-07-18 14:05 ` Nithyanantham Paramasivam
2025-07-18 16:30 ` Jeff Johnson
2025-07-18 2:55 ` [PATCH ath-next v2 3/3] wifi: ath12k: Advertise encapsulation/decapsulation offload support to mac80211 Nithyanantham Paramasivam
2025-07-18 16:11 ` [PATCH ath-next v2 0/3] wifi: ath12k: Add 802.11 encap/decap offload support Vasanthakumar Thiagarajan
2025-07-19 16:22 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae4000edd954cf492e95bdb059c89b2@realtek.com \
--to=pkshih@realtek.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nithyanantham.paramasivam@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox