From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] mac80211: fix beacon interval value
Date: Thu, 12 Jun 2008 23:05:37 +0300 [thread overview]
Message-ID: <1ba2fa240806121305h721c6bd2x8073660d41653b92@mail.gmail.com> (raw)
In-Reply-To: <1213299706.3730.39.camel@johannes.berg>
On Thu, Jun 12, 2008 at 10:41 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>> 1. in register_hw it honors value requested by the driver
>
> I don't think the driver should be able to "request" a value.
Yes and no.
The problem is that we don't have user space interface to tune this
for IBSS so in this circumstances
driver can choose what value is best for it.
Tomas
>
>> 2. It uses default 100 instead of 1000 or 10000. Scanning for beacon
>> interval ~1sec and above is not sane
>
> Yeah, 10000 seems a bit excessive.
Actually this never took affect as there is no way that 0 is assigned
to hw->conf.beacon_int but even 1000 is edgy and not suitable for a
default value.
Tomas
next prev parent reply other threads:[~2008-06-12 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 19:38 [PATCH 1/1] mac80211: fix beacon interval value Tomas Winkler
2008-06-12 19:41 ` Johannes Berg
2008-06-12 20:05 ` Tomas Winkler [this message]
2008-06-12 20:08 ` Johannes Berg
2008-06-12 20:47 ` Tomas Winkler
2008-06-12 20:53 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240806121305h721c6bd2x8073660d41653b92@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox