Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, yi.zhu@intel.com,
	linux-wireless@vger.kernel.org,
	"Assaf Krauss" <assaf.krauss@intel.com>
Subject: Re: [PATCH 2/2 V2] mac80211: 11h - Handling measurement request
Date: Mon, 16 Jun 2008 16:06:50 +0300	[thread overview]
Message-ID: <1ba2fa240806160606g379747aam473bd4a3620ce72@mail.gmail.com> (raw)
In-Reply-To: <1213620760.3803.30.camel@johannes.berg>

On Mon, Jun 16, 2008 at 3:52 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Mon, 2008-06-16 at 14:20 +0300, Tomas Winkler wrote:
>> From: Assaf Krauss <assaf.krauss@intel.com>
>>
>> This patch handles the 11h measurement request information element.
>> This is minimal requested implementation - refuse measurement.
>>
>> Signed-off-by: Assaf Krauss <assaf.krauss@intel.com>
>> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Looks fine to me.
>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
>
>
>> +/* measurement */
>> +#define IEEE80211_SPCT_MSR_RPRT_MODE_LATE    (1<<0)
>> +#define IEEE80211_SPCT_MSR_RPRT_MODE_INCAPABLE       (1<<1)
>> +#define IEEE80211_SPCT_MSR_RPRT_MODE_RFEUSED (1<<2)
>                                        ^^^^^^^ typo
>
>> +     msr_report->u.action.u.measurement.msr_elem.mode |=
>> +                     IEEE80211_SPCT_MSR_RPRT_MODE_RFEUSED;
>
> search & replace? :)
>
Oh, okay will send V3 :(

> johannes
>

      reply	other threads:[~2008-06-16 13:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16 11:20 [PATCH 2/2 V2] mac80211: 11h - Handling measurement request Tomas Winkler
2008-06-16 12:52 ` Johannes Berg
2008-06-16 13:06   ` Tomas Winkler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba2fa240806160606g379747aam473bd4a3620ce72@mail.gmail.com \
    --to=tomasw@gmail.com \
    --cc=assaf.krauss@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox