From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from yx-out-2324.google.com ([74.125.44.28]:32813 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754791AbYFSOpf (ORCPT ); Thu, 19 Jun 2008 10:45:35 -0400 Received: by yx-out-2324.google.com with SMTP id 31so126888yxl.1 for ; Thu, 19 Jun 2008 07:45:34 -0700 (PDT) Message-ID: <1ba2fa240806190745u2fe7e435y3ca207af4156767b@mail.gmail.com> (sfid-20080619_164711_729420_F96B24CD) Date: Thu, 19 Jun 2008 17:45:34 +0300 From: "Tomas Winkler" To: "Johannes Berg" Subject: Re: Broken fragmentation Cc: "Linux Wireless" In-Reply-To: <1213881855.8967.19.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1ba2fa240806190220l18fe5dcdsf44fe81412a5f35d@mail.gmail.com> <1213869365.1312.48.camel@johannes.berg> <1ba2fa240806190446n4d931e6ara4db156900e59e0d@mail.gmail.com> <1ba2fa240806190457w20dfe2d5pf06829b26d2722a3@mail.gmail.com> <1213878207.8967.6.camel@johannes.berg> <1ba2fa240806190608h3d833dbaua412446e8a9f560d@mail.gmail.com> <1213881855.8967.19.camel@johannes.berg> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Jun 19, 2008 at 4:24 PM, Johannes Berg wrote: > On Thu, 2008-06-19 at 16:08 +0300, Tomas Winkler wrote: >> On Thu, Jun 19, 2008 at 3:23 PM, Johannes Berg >> wrote: >> > >> >> > Now it crashes in the driver...maybe the txinfo to cb changes. Looking into it. >> >> > Tomas >> >> Looks like this is the second part keyconf is null >> > >> > Part? You mean fragment? What encryption algorithm? I've quickly looked >> > and all of them seem to do the control.hw_key assignment in their >> > respective _skb handler so it should be done for all fragments. >> >> The problem is w/o crypto >> I think this is not set on each fragment >> info->flags |= IEEE80211_TX_CTL_DO_NOT_ENCRYPT; > > Ouch, you're right, the whole tx info isn't properly initialised for > fragments. > > Can you try putting > > memcpy(frag->cb, first->cb, sizeof(first->cb)); > > at around line 690 of tx.c where this code is? > > frag->priority = first->priority; > skb_reserve(frag, tx->local->tx_headroom + > IEEE80211_ENCRYPT_HEADROOM); > > > [now I know what the cause is. I had another patch that used skb_segment > to do the fragmentation, but that was dropped and skb_segment does copy > skb->cb while our code doesn't] No crash but still not at home. No fragmented traffic on the air...grrr. Tomas