From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from py-out-1112.google.com ([64.233.166.176]:62923 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753367AbYFYKaV (ORCPT ); Wed, 25 Jun 2008 06:30:21 -0400 Received: by py-out-1112.google.com with SMTP id p76so1647078pyb.10 for ; Wed, 25 Jun 2008 03:30:20 -0700 (PDT) Message-ID: <1ba2fa240806250330s15168d22i50e61498fbba6af7@mail.gmail.com> (sfid-20080625_123024_703387_8D5DB42F) Date: Wed, 25 Jun 2008 13:30:19 +0300 From: "Tomas Winkler" To: "Johannes Berg" Subject: Re: Broken fragmentation Cc: "Linux Wireless" In-Reply-To: <1214388133.21847.8.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1ba2fa240806190220l18fe5dcdsf44fe81412a5f35d@mail.gmail.com> <1213881855.8967.19.camel@johannes.berg> <1ba2fa240806190745u2fe7e435y3ca207af4156767b@mail.gmail.com> <1213889200.8967.26.camel@johannes.berg> <1ba2fa240806191113nd6a221eiac9648edd3404a80@mail.gmail.com> <1213899419.8967.59.camel@johannes.berg> <1ba2fa240806191409k7200ad53y654a7f8a117c8f14@mail.gmail.com> <1213910734.8967.117.camel@johannes.berg> <1ba2fa240806250250k2ae66eddre00172f6bc871fcb@mail.gmail.com> <1214388133.21847.8.camel@johannes.berg> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 25, 2008 at 1:02 PM, Johannes Berg wrote: > On Wed, 2008-06-25 at 12:50 +0300, Tomas Winkler wrote: >> On Fri, Jun 20, 2008 at 12:25 AM, Johannes Berg >> wrote: >> > >> >> >> Fragments are in the air but the peer is not able to reassemble them. >> >> >> Something is wrong with the first fragment but I'm not sure yet. >> >> > >> >> > Hm, ok. got a packet capture? Maybe that was broken before, I remember >> >> > having problems with fragmentation but putting it down to the >> >> > known-to-be-completely-broken AP I was using. >> >> >> >> It is working the latest problem was caused by the driver, Yet i still >> >> don't understand the regression >> >> in the driver. >> > >> > Hmm, ok. >> > >> So the bug is still in mac80211. Fragments are scheduled to different >> TIDs and hence to different queues. >> Investigating further. If you have something in mind let me know > > Hmm, yes, I do indeed, try > > skb_copy_queue_mapping(frag, first); > > where you previously added the cb copy. Yeah just found that too 2 min ago :) Thanks Tomas