Re: [PATCH 1/1] mac80211: Fix ieee80211_rx_reorder_ampdu: ignore QoS null packets

["Tomas Winkler" <tomasw@gmail.com>]

On Mon, Jul 7, 2008 at 3:37 PM, Stefanik G=E1bor <netrolller.3d@gmail.c=
om> wrote:
> On Mon, Jul 7, 2008 at 2:32 PM, Tomas Winkler <tomas.winkler@intel.co=
m> wrote:
>> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>>
>> This patch fixes the check at the entrance to ieee80211_rx_reorder_a=
mpdu.
>> This check has been broken by 511fe3f3c4ba0b5b77421336f64a19b6cd00e6=
5f
>> 'mac80211: rx.c use new helpers'
>>
>> Letting QoS NULL packet in ieee80211_rx_reorder_ampdu led to packet =
loss in
>> RX.
>>
>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>> ---
>>  include/linux/ieee80211.h |   11 +++++++++++
>>  net/mac80211/rx.c         |    2 +-
>>  2 files changed, 12 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
>> index aa603c3..3865d4c 100644
>> --- a/include/linux/ieee80211.h
>> +++ b/include/linux/ieee80211.h
>> @@ -460,6 +460,17 @@ static inline int ieee80211_is_nullfunc(__le16 =
fc)
>>               cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_NUL=
LFUNC);
>>  }
>>
>> +/**
>> + * ieee80211_is_nullfunc - check if FTYPE=3DIEEE80211_FTYPE_DATA an=
d
>
> Was this intended to be "ieee80211_is_qos_nullfunc - check..."?
Thanks. V2 was posted.
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html