From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Zhu Yi" <yi.zhu@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH 05/13] iwlwifi: use dtim_period from association, and set listen_interval
Date: Fri, 18 Jul 2008 11:53:05 +0300 [thread overview]
Message-ID: <1ba2fa240807180153hcb27158qb79e1af893fd2a46@mail.gmail.com> (raw)
In-Reply-To: <1216369409.27738.2.camel@johannes.berg>
On Fri, Jul 18, 2008 at 11:23 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>> --- a/drivers/net/wireless/iwlwifi/iwl-core.c
>> +++ b/drivers/net/wireless/iwlwifi/iwl-core.c
>> @@ -828,6 +828,7 @@ int iwl_setup_mac(struct iwl_priv *priv)
>> hw->ampdu_queues = priv->cfg->mod_params->num_of_ampdu_queues;
>>
>> hw->conf.beacon_int = 100;
>> + hw->conf.listen_interval = IWL_CONN_LISTEN_INTERVAL;
>>
>
> No way. How did those get in there? mac80211 is supposed to control the
> config, and you're supposed to use them. That was the whole point of the
> discussion we had. Please remove the beacon_int line as well and use the
> setting you get instead.
Mistake in sync with Yi, please ignore this patch. I'll post the correct one.
Tomas
> johannes
>
prev parent reply other threads:[~2008-07-18 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 5:52 [PATCH 00/13] iwlwifi driver 07/18 updates Zhu Yi
2008-07-18 5:52 ` [PATCH 01/13] iwlwifi: add power save to 5000 HW Zhu Yi
2008-07-18 5:52 ` [PATCH 02/13] iwlwifi: corrects power_level in sysfs Zhu Yi
2008-07-18 5:52 ` [PATCH 03/13] mac80211: pass dtim_period to low level driver Zhu Yi
2008-07-18 5:53 ` [PATCH 04/13] mac80211: make listen_interval be limited by " Zhu Yi
2008-07-18 5:53 ` [PATCH 05/13] iwlwifi: use dtim_period from association, and set listen_interval Zhu Yi
2008-07-18 5:53 ` [PATCH 06/13] iwlwifi: move iwl4965_mac_ampdu_action to iwl4965-base.c Zhu Yi
2008-07-18 5:53 ` [PATCH 07/13] iwlwifi: move beacon handling " Zhu Yi
2008-07-18 5:53 ` [PATCH 08/13] iwlwifi: move iwl4965_set_pwr_src " Zhu Yi
2008-07-18 5:53 ` [PATCH 09/13] iwlwifi: rename iwl-4695-rs to iwl-agn-rs Zhu Yi
2008-07-18 5:53 ` [PATCH 10/13] iwlwifi: kill iwl4965_fill_rs_info Zhu Yi
2008-07-18 5:53 ` [PATCH 11/13] iwlwifi: set led register in disassociation Zhu Yi
2008-07-18 5:53 ` [PATCH 12/13] mac80211: remove unused variable agg_queue Zhu Yi
2008-07-18 5:53 ` [PATCH 13/13] iwlwifi: bug fix in AGG flow - cast const to ULL Zhu Yi
2008-07-18 8:23 ` [PATCH 05/13] iwlwifi: use dtim_period from association, and set listen_interval Johannes Berg
2008-07-18 8:53 ` Tomas Winkler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240807180153hcb27158qb79e1af893fd2a46@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox