From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "John Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: fill start-sequence-number for BA session start
Date: Thu, 7 Aug 2008 19:45:39 +0300 [thread overview]
Message-ID: <1ba2fa240808070945u961bdb5tb19eefe27a144729@mail.gmail.com> (raw)
In-Reply-To: <1218090814.23048.86.camel@johannes.berg>
On Thu, Aug 7, 2008 at 9:33 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Thu, 2008-08-07 at 01:42 +0300, Tomas Winkler wrote:
>> On Wed, Aug 6, 2008 at 10:45 PM, Johannes Berg
>> <johannes@sipsolutions.net> wrote:
>> > Otherwise, drivers are required to keep track of the sequence numbers
>> > themselves, and they really shouldn't be since we already do it for
>> > them. I'll fix the race once we figure out how this code should work
>> > at all, it's currently disabled.
>> >
>> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>>
>> Finally I know why nothing works in iwlwifi. This is most crucial
>> point of correct driver behavior.
>> There is direct mapping between hw queue indexes and sequence numbers....
>> This is bad.
>
> Eh, this particular patch has nothing to do with iwlwifi at all because
> iwlwifi overrides all sequence numbers anyway.
I'm not referring to this patch but to expected behavior that was broken.
Second I'm not sure mac should keep track of sequence numbers. In
theory driver can drop packets in processing
and this may confuse sequence progress. I've already wrote about it...
Tomas
next prev parent reply other threads:[~2008-08-07 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 19:45 [PATCH] mac80211: fill start-sequence-number for BA session start Johannes Berg
2008-08-06 22:42 ` Tomas Winkler
2008-08-07 6:33 ` Johannes Berg
2008-08-07 16:45 ` Tomas Winkler [this message]
2008-08-07 16:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240808070945u961bdb5tb19eefe27a144729@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox