Re: [RFC PATCH 3/3] mac80211: remove disassociation code from ieee80211_set_associated

Tomas Winkler
2008-09-06T22:33:59Z

On Sun, Sep 7, 2008 at 1:30 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Sun, 2008-09-07 at 01:14 +0300, Tomas Winkler wrote:
>
>> - ieee80211_led_assoc(local, assoc);
>> + ieee80211_led_assoc(local, 1);
>>
>> - sdata->bss_conf.assoc = assoc;
>> + sdata->bss_conf.assoc = 1;
>
> I think you should use "true" at least for the latter "1"
>
>> + sdata->bss_conf.assoc = 0;
>
> and "false" here, and if the LED interface uses "bool" then for that
> too.
>
> The actual patch looks good to me though.

Will do
Thanks
Tomas