Re: [RFC PATCH 3/3] mac80211: remove disassociation code from ieee80211_set_associated

Johannes Berg
2008-09-06T22:30:36Z

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

On Sun, 2008-09-07 at 01:14 +0300, Tomas Winkler wrote:

> - ieee80211_led_assoc(local, assoc);
> + ieee80211_led_assoc(local, 1);
>
> - sdata->bss_conf.assoc = assoc;
> + sdata->bss_conf.assoc = 1;

I think you should use "true" at least for the latter "1"

> + sdata->bss_conf.assoc = 0;

and "false" here, and if the LED interface uses "bool" then for that
too.

The actual patch looks good to me though.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]