Re: [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows

Tomas Winkler
2008-09-06T22:32:48Z

On Sun, Sep 7, 2008 at 1:25 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
>
>>
>> +static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
>> + struct ieee80211_if_sta *ifsta, int deauth,
>> + int self_disconnected, u16 reason)
>
> I think you should use bool for those two (deauth, self)

I'm thinking rather using some enum values just for readability
foo(DEAUTH, ORIGIN_SELF) vs foo(tree,true)
foo(DISASSOC, ORIGIN_PEER) vs foo(false, false)

>> + rcu_read_unlock();
>> +
>> + sta_info_unlink(&sta);
>
> Those need to be the other way around.

Will do,
Thanks
Tomas