linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Zhu Yi" <yi.zhu@intel.com>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Kolekar, Abhijeet" <abhijeet.kolekar@intel.com>
Subject: Re: [PATCH] iwl3945: added channel sysfs entry
Date: Thu, 25 Sep 2008 14:50:42 +0300	[thread overview]
Message-ID: <1ba2fa240809250450x319d21bbr4e0fb072e47c60db@mail.gmail.com> (raw)
In-Reply-To: <1222341663.10563.67.camel@johannes.berg>

>
> Didn't see it on iwl3945, but I only looked for the function that the
> sysfs code calls and didn't find any other callsite, might well be a
> different way.

Might be case for 3945 I'm less involved in that one.


>
>> except log level
>> which I want always visible and has proven to be most useful.
>
> Yeah, indeed, though it seems to be notably lacking printing out the
> physical addresses and the ringbuffer entries. But that's just the thing
> I was looking for yesterday when debugging the corruption issue.

I should have patches for that somewhere got lost somewhere in
selective merging, will bring them forward.

>> > generic option to disable hardware crypto in _mac80211_ rather than each
>> > driver because this is actually genuinely useful if you want to monitor
>> > frames at the same time.
>
>> This is good point also disabling and enabling hw scan I would like to
>> remove from module params.
>
> That would be doable via mac80211 too, though that is a much more debug
> option than disabling hardware crypto, I see disabling hw crypto as much
> more useful than disabling hw scan.

I would probably remove the option of disabling hw scan at all, think
it's stable enough.
Tomas

  reply	other threads:[~2008-09-25 11:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24  5:57 [PATCH] iwl3945: added channel sysfs entry Zhu Yi
2008-09-24  5:57 ` [PATCH] iwlwifi: don't fail if scan is issued too early Zhu Yi
2008-09-24  8:44 ` [PATCH] iwl3945: added channel sysfs entry Johannes Berg
2008-09-24 10:52   ` Dan Williams
2008-09-25  7:34   ` Zhu Yi
2008-09-25  9:23     ` Johannes Berg
2008-09-25 11:04       ` Tomas Winkler
2008-09-25 11:21         ` Johannes Berg
2008-09-25 11:50           ` Tomas Winkler [this message]
2008-09-26  3:54       ` Zhu Yi
2008-09-26  4:13         ` Luis R. Rodriguez
2008-09-26  5:13           ` Zhu Yi
2008-09-26  5:16             ` Zhu Yi
2008-09-26  5:28           ` Zhu Yi
2008-09-26  5:39             ` Luis R. Rodriguez
2008-09-26  5:40               ` Luis R. Rodriguez
2008-09-26  5:44               ` Zhu Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba2fa240809250450x319d21bbr4e0fb072e47c60db@mail.gmail.com \
    --to=tomasw@gmail.com \
    --cc=abhijeet.kolekar@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).