Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "John Linville" <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH for 2.6.28] mac80211: fix basic rates
Date: Thu, 30 Oct 2008 16:39:03 +0200	[thread overview]
Message-ID: <1ba2fa240810300739m69ec943didc1d76b82da7f1e5@mail.gmail.com> (raw)
In-Reply-To: <1225376692.3690.46.camel@johannes.berg>

On Thu, Oct 30, 2008 at 4:24 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2008-10-30 at 15:23 +0200, Tomas Winkler wrote:
>> On Wed, Oct 29, 2008 at 7:14 PM, Johannes Berg
>> <johannes@sipsolutions.net> wrote:
>> > This fixes the basic rate bitmap calculation in mac80211.
>> >
>> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>> > Cc: stable@kernel.org [2.6.25, 2.6.26, 2.6.27]
>> > ---
>> > Is this appropriate for stable? It's a trivial and obvious fix, and can
>> > throw off the duration calculation, but it's likely nobody will ever
>> > really notice...
>>
>> You would should fail association if one of the basic rates is not
>> supported  by the station
>
> No, this has nothing to do with association, it's just setting the
> internal variable about which rates are basic in the BSS.

I understand that but What your patch is doing it is preventing
of setting basic rates for ratest that are not sported by the driver,
but according
the spec it is not permissible that driver will not support one of the
basic rates.

Tomas

  reply	other threads:[~2008-10-30 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 17:14 [PATCH for 2.6.28] mac80211: fix basic rates Johannes Berg
2008-10-30 13:23 ` Tomas Winkler
2008-10-30 14:24   ` Johannes Berg
2008-10-30 14:39     ` Tomas Winkler [this message]
2008-10-30 14:41       ` Johannes Berg
2008-10-30 14:51         ` Tomas Winkler
2008-10-30 14:54           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba2fa240810300739m69ec943didc1d76b82da7f1e5@mail.gmail.com \
    --to=tomasw@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox