Re: [PATCHv8 0/6] cfg80211/mac80211: Add support for TID specific configuration

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2019-11-08 at 12:05 +0000, Sergey Matyukevich wrote:

> > @NL80211_TID_CONFIG_ATTR_OVERRIDE: flag attribute, valid only if no STA
> > 	is selected, if set indicates that the new configuration
> > 	overrides all previous STA configurations, otherwise previous
> > 	STA-specific configurations should be left untouched
> > 
> > You also raise a good point wrt. "all TIDs" - but then we should
> > probably just remove NL80211_TID_CONFIG_ATTR_TID and add a new
> > NL80211_TID_CONFIG_ATTR_TIDS as a bitmap? OTOH, it's not hard to just
> > explicitly spell out all TIDs either, I guess, just makes the message a
> > bit bigger.
> 
> The idea with bitmask for TIDs looks good. It eliminates the need for both
> 'all TIDs' define and additional attribute NL80211_TID_CONFIG_ATTR_OVERRIDE.

I think we still need NL80211_TID_CONFIG_ATTR_OVERRIDE in some way
(maybe only as a flag attribute), since you could have

 * change all stations (some subset of TIDs) *including* already
   configured stations
 * or *excluding* already configured stations

> In fact, almost no changes are needed for the patch, mostly comments need
> to be updated. Manual typing in iw will be less convenient, but I guess
> this interface is not supposed to be used by humans after all...

If that's a concern we can parse a list in iw, e.g. "0,1,2,3" instaed of
"0xf", right?

johannes