From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org, johannes.berg@intel.com
Subject: Re: [PATCH] brcmfmac: Fix error pointer dereference
Date: Mon, 9 Mar 2026 11:13:40 +0100 [thread overview]
Message-ID: <1cc4caff-41fc-4827-8b29-18964b41b49a@broadcom.com> (raw)
In-Reply-To: <20260217023043.73631-1-ethantidmore06@gmail.com>
On 17/02/2026 03:30, Ethan Tidmore wrote:
> The function brcmf_chip_add_core() can return an error pointer and is
> not checked. Add checks for error pointer.
>
> Detected by Smatch:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1010 brcmf_chip_recognition() error:
> 'core' dereferencing possible ERR_PTR()
[...]
> Fixes: cb7cf7be9eba7 ("brcmfmac: make chip related functions host interface independent")
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
> .../wireless/broadcom/brcm80211/brcmfmac/chip.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
prev parent reply other threads:[~2026-03-09 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 2:30 [PATCH] brcmfmac: Fix error pointer dereference Ethan Tidmore
2026-03-09 10:13 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cc4caff-41fc-4827-8b29-18964b41b49a@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=ethantidmore06@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox