* [PATCH] wifi: rtlwifi: fix EDCA limit to set
@ 2023-09-27 14:04 Dmitry Antipov
2023-09-28 2:18 ` Ping-Ke Shih
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Antipov @ 2023-09-27 14:04 UTC (permalink / raw)
To: Ping-Ke Shih; +Cc: Kalle Valo, linux-wireless, Dmitry Antipov
In 'rtl92c_dm_check_edca_turbo()', most likely the DL limit should
be set from the corresponding field of 'rtlpriv->btcoexist' rather
than UL. Compile tested only.
Fixes: beb5bc402043 ("rtlwifi: rtl8192c-common: Convert common dynamic management routines for addition of rtl8192se and rtl8192de")
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
index 0b6a15c2e5cc..d92aad60edfe 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
@@ -640,7 +640,7 @@ static void rtl92c_dm_check_edca_turbo(struct ieee80211_hw *hw)
}
if (rtlpriv->btcoexist.bt_edca_dl != 0) {
- edca_be_ul = rtlpriv->btcoexist.bt_edca_dl;
+ edca_be_dl = rtlpriv->btcoexist.bt_edca_dl;
bt_change_edca = true;
}
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] wifi: rtlwifi: fix EDCA limit to set
2023-09-27 14:04 [PATCH] wifi: rtlwifi: fix EDCA limit to set Dmitry Antipov
@ 2023-09-28 2:18 ` Ping-Ke Shih
2023-09-28 5:23 ` [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence Dmitry Antipov
0 siblings, 1 reply; 5+ messages in thread
From: Ping-Ke Shih @ 2023-09-28 2:18 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Kalle Valo, linux-wireless@vger.kernel.org
> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Wednesday, September 27, 2023 10:05 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; Dmitry Antipov <dmantipov@yandex.ru>
> Subject: [PATCH] wifi: rtlwifi: fix EDCA limit to set
"wifi: rtlwifi: 8192c: fix EDCA limit set by BT coexistence"
would be clearer.
>
> In 'rtl92c_dm_check_edca_turbo()', most likely the DL limit should
> be set from the corresponding field of 'rtlpriv->btcoexist' rather
> than UL. Compile tested only.
>
> Fixes: beb5bc402043 ("rtlwifi: rtl8192c-common: Convert common dynamic management routines for addition
> of rtl8192se and rtl8192de")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
> index 0b6a15c2e5cc..d92aad60edfe 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
> @@ -640,7 +640,7 @@ static void rtl92c_dm_check_edca_turbo(struct ieee80211_hw *hw)
> }
>
> if (rtlpriv->btcoexist.bt_edca_dl != 0) {
> - edca_be_ul = rtlpriv->btcoexist.bt_edca_dl;
> + edca_be_dl = rtlpriv->btcoexist.bt_edca_dl;
> bt_change_edca = true;
> }
>
> --
> 2.41.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence
2023-09-28 2:18 ` Ping-Ke Shih
@ 2023-09-28 5:23 ` Dmitry Antipov
2023-10-03 0:18 ` Ping-Ke Shih
2023-10-03 11:43 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Dmitry Antipov @ 2023-09-28 5:23 UTC (permalink / raw)
To: Ping-Ke Shih; +Cc: Kalle Valo, linux-wireless, Dmitry Antipov
In 'rtl92c_dm_check_edca_turbo()', 'rtl88e_dm_check_edca_turbo()',
and 'rtl8723e_dm_check_edca_turbo()', the DL limit should be set
from the corresponding field of 'rtlpriv->btcoexist' rather than
UL. Compile tested only.
Fixes: 0529c6b81761 ("rtlwifi: rtl8723ae: Update driver to match 06/28/14 Realtek version")
Fixes: c151aed6aa14 ("rtlwifi: rtl8188ee: Update driver to match Realtek release of 06282014")
Fixes: beb5bc402043 ("rtlwifi: rtl8192c-common: Convert common dynamic management routines for addition of rtl8192se and rtl8192de")
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
v2: adjust title (Ping-Ke Shih) and add similar fixes for
rtl8723ae and rtl8188ee
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
index 6f61d6a10627..5a34894a533b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
@@ -799,7 +799,7 @@ static void rtl88e_dm_check_edca_turbo(struct ieee80211_hw *hw)
}
if (rtlpriv->btcoexist.bt_edca_dl != 0) {
- edca_be_ul = rtlpriv->btcoexist.bt_edca_dl;
+ edca_be_dl = rtlpriv->btcoexist.bt_edca_dl;
bt_change_edca = true;
}
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
index 0b6a15c2e5cc..d92aad60edfe 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
@@ -640,7 +640,7 @@ static void rtl92c_dm_check_edca_turbo(struct ieee80211_hw *hw)
}
if (rtlpriv->btcoexist.bt_edca_dl != 0) {
- edca_be_ul = rtlpriv->btcoexist.bt_edca_dl;
+ edca_be_dl = rtlpriv->btcoexist.bt_edca_dl;
bt_change_edca = true;
}
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
index 8ada31380efa..0ff8e355c23a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/dm.c
@@ -466,7 +466,7 @@ static void rtl8723e_dm_check_edca_turbo(struct ieee80211_hw *hw)
}
if (rtlpriv->btcoexist.bt_edca_dl != 0) {
- edca_be_ul = rtlpriv->btcoexist.bt_edca_dl;
+ edca_be_dl = rtlpriv->btcoexist.bt_edca_dl;
bt_change_edca = true;
}
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence
2023-09-28 5:23 ` [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence Dmitry Antipov
@ 2023-10-03 0:18 ` Ping-Ke Shih
2023-10-03 11:43 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Ping-Ke Shih @ 2023-10-03 0:18 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Kalle Valo, linux-wireless@vger.kernel.org
> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Thursday, September 28, 2023 1:23 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; Dmitry Antipov <dmantipov@yandex.ru>
> Subject: [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence
>
> In 'rtl92c_dm_check_edca_turbo()', 'rtl88e_dm_check_edca_turbo()',
> and 'rtl8723e_dm_check_edca_turbo()', the DL limit should be set
> from the corresponding field of 'rtlpriv->btcoexist' rather than
> UL. Compile tested only.
>
> Fixes: 0529c6b81761 ("rtlwifi: rtl8723ae: Update driver to match 06/28/14 Realtek version")
> Fixes: c151aed6aa14 ("rtlwifi: rtl8188ee: Update driver to match Realtek release of 06282014")
> Fixes: beb5bc402043 ("rtlwifi: rtl8192c-common: Convert common dynamic management routines for addition
> of rtl8192se and rtl8192de")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence
2023-09-28 5:23 ` [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence Dmitry Antipov
2023-10-03 0:18 ` Ping-Ke Shih
@ 2023-10-03 11:43 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2023-10-03 11:43 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Ping-Ke Shih, linux-wireless, Dmitry Antipov
Dmitry Antipov <dmantipov@yandex.ru> wrote:
> In 'rtl92c_dm_check_edca_turbo()', 'rtl88e_dm_check_edca_turbo()',
> and 'rtl8723e_dm_check_edca_turbo()', the DL limit should be set
> from the corresponding field of 'rtlpriv->btcoexist' rather than
> UL. Compile tested only.
>
> Fixes: 0529c6b81761 ("rtlwifi: rtl8723ae: Update driver to match 06/28/14 Realtek version")
> Fixes: c151aed6aa14 ("rtlwifi: rtl8188ee: Update driver to match Realtek release of 06282014")
> Fixes: beb5bc402043 ("rtlwifi: rtl8192c-common: Convert common dynamic management routines for addition of rtl8192se and rtl8192de")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
3391ee7f9ea5 wifi: rtlwifi: fix EDCA limit set by BT coexistence
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230928052327.120178-1-dmantipov@yandex.ru/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-03 11:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 14:04 [PATCH] wifi: rtlwifi: fix EDCA limit to set Dmitry Antipov
2023-09-28 2:18 ` Ping-Ke Shih
2023-09-28 5:23 ` [PATCH] [v2] wifi: rtlwifi: fix EDCA limit set by BT coexistence Dmitry Antipov
2023-10-03 0:18 ` Ping-Ke Shih
2023-10-03 11:43 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).