From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Dan Carpenter <error27@gmail.com>,
Christian Lamparter <chunkeey@googlemail.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] wifi: carl9170: NUL terminate string in debugfs
Date: Sat, 3 Oct 2026 15:49:33 -0700 [thread overview]
Message-ID: <1ec8a2b9-7855-49d5-9ef1-018aeb3ead01@oss.qualcomm.com> (raw)
In-Reply-To: <674270ab4aeefa1982362c0ea4132427e14f15eb.1790839793.git.error27@gmail.com>
On 10/1/2026 12:37 AM, Dan Carpenter wrote:
> The "buf" buffer comes from the user. We use it to store a number or
> two so it doesn't need to be large. It gets passed to sscanf() in the
> write functions such as carl9170_debugfs_erp_write(). Ensure that
> buffer is NUL terminated.
>
> This is debugfs so it's root only.
>
> Fixes: 00c4da27a421 ("carl9170: firmware parser and debugfs code")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Johannes, since the other two in the series go through your tree, you might as
well take all three. I've assigned this one to you in patchwork.
Acked-by: Jeff Johnson <jjohnson@kernel.org>
prev parent reply other threads:[~2026-10-03 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 7:37 [PATCH 0/3] wifi: NULL terminate some user strings Dan Carpenter
2026-10-01 7:37 ` [PATCH 1/3] wifi: b43: don't pass unterminated string to sscanf() Dan Carpenter
2026-10-01 7:37 ` [PATCH 2/3] wifi: b43legacy: debugfs: NUL terminate string in debugfs Dan Carpenter
2026-10-01 7:37 ` [PATCH 3/3] wifi: carl9170: " Dan Carpenter
2026-10-01 17:58 ` Christian Lamparter
2026-10-01 18:31 ` Dan Carpenter
2026-10-03 22:49 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec8a2b9-7855-49d5-9ef1-018aeb3ead01@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=chunkeey@googlemail.com \
--cc=error27@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox