From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Roopni Devanathan <quic_rdevanat@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: Modify print_array_to_buf() to support arrays with 1-based semantics
Date: Thu, 3 Oct 2024 07:56:49 -0700 [thread overview]
Message-ID: <1f1e74a7-3ab6-4a92-84a1-ee157b7cd11f@quicinc.com> (raw)
In-Reply-To: <20240730035154.3723773-1-quic_rdevanat@quicinc.com>
On 7/29/2024 8:51 PM, Roopni Devanathan wrote:
> The API print_array_to_buf() currently supports printing
> arrays with 0 indexing. In some cases, a few arrays need
> to be printed with 1-based indexing, i.e., array should be
> printed, starting with 1.
>
> Add a new version of print_array_to_buf(), named
> print_array_to_buf_v2(), which implements the functionality
> of print_array_to_buf(), but with an extra variable,
> pointing to the index starting with which the array should
> be printed. Modify print_array_to_buf() to call
> print_array_to_buf_v2() with 0 as the starting index.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Roopni Devanathan <quic_rdevanat@quicinc.com>
I'm in the process of pulling in this change and the dependent debugfs
patches, but was never quite happy with the naming of the new function.
Discussed with Kalle and suggest the new function be called something like
print_array_to_buf_index() so that the new name has some semantic guidance to
how it is different.
Can you update this patch and the dependent ones to use this name?
/jeff
next prev parent reply other threads:[~2024-10-03 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 3:51 [PATCH] wifi: ath12k: Modify print_array_to_buf() to support arrays with 1-based semantics Roopni Devanathan
2024-07-30 15:10 ` Jeff Johnson
2024-07-30 16:32 ` Jeff Johnson
2024-10-03 14:56 ` Jeff Johnson [this message]
2024-10-04 8:57 ` Roopni Devanathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f1e74a7-3ab6-4a92-84a1-ee157b7cd11f@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rdevanat@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox