linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jouni Malinen <jkmaline@cc.hut.fi>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] d80211: Add API to generate RTS and CTS-to-self frames
Date: Mon, 5 Feb 2007 06:58:25 -0800	[thread overview]
Message-ID: <20070205145824.GA6637@jm.kir.nu> (raw)
In-Reply-To: <200702051412.50703.mb@bu3sch.de>

On Mon, Feb 05, 2007 at 02:12:50PM +0100, Michael Buesch wrote:

> This adds API calls to generate RTS and CTS-to-self frames.
> To be called if the device firmware requires the host to
> generate RTS/CTS frames.

I understand the part of adding this. However..

> Index: bu3sch-wireless-dev/include/linux/ieee80211.h

> Index: bu3sch-wireless-dev/include/net/d80211.h
> ===================================================================
> --- bu3sch-wireless-dev.orig/include/net/d80211.h	2007-02-05 13:59:34.000000000 +0100
> +++ bu3sch-wireless-dev/include/net/d80211.h	2007-02-05 14:01:30.000000000 +0100
> @@ -194,7 +194,6 @@ struct ieee80211_tx_control {
>  #define IEEE80211_TXCTL_TKIP_NEW_PHASE1_KEY (1<<9)
>  	u32 flags;			       /* tx control flags defined
>  						* above */
> -	u16 rts_cts_duration;	/* duration field for RTS/CTS frame */
>  	u8 retry_limit;		/* 1 = only first attempt, 2 = one retry, .. */
>  	u8 power_level;		/* per-packet transmit power level, in dBm */
>  	u8 antenna_sel; 	/* 0 = default/diversity, 1 = Ant0, 2 = Ant1 */

NAK. Why are you removing this? It is needed for hardware that generates
RTS/CTS frames.

-- 
Jouni Malinen                                            PGP id EFC895FA

  parent reply	other threads:[~2007-02-05 14:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05 13:12 [PATCH] d80211: Add API to generate RTS and CTS-to-self frames Michael Buesch
2007-02-05 13:14 ` [PATCH] bcm43xx-d80211: Use d80211 API to generate RTS/CTS frames Michael Buesch
2007-02-05 13:15 ` [PATCH] rt2x00-d80211: " Michael Buesch
2007-02-05 13:31 ` [PATCH] d80211: Add API to generate RTS and CTS-to-self frames Michael Buesch
2007-02-05 13:43 ` Johannes Berg
2007-02-05 13:53   ` Michael Buesch
2007-02-05 14:58 ` Jouni Malinen [this message]
2007-02-05 15:28   ` Michael Buesch
2007-02-05 16:47     ` Jouni Malinen
2007-02-05 16:53       ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070205145824.GA6637@jm.kir.nu \
    --to=jkmaline@cc.hut.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).