From: Jiri Benc <jbenc@suse.cz>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Michael Buesch <mb@bu3sch.de>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] d80211: remove hosttime from ieee80211_rx_status
Date: Fri, 9 Feb 2007 18:15:13 +0100 [thread overview]
Message-ID: <20070209181513.66fdec56@griffin.suse.cz> (raw)
In-Reply-To: <200702091056.46679.flamingice@sourmilk.net>
On Fri, 9 Feb 2007 10:56:42 -0500, Michael Wu wrote:
> @@ -4096,13 +4084,12 @@ static void ieee80211_tasklet_handler(un
> (skb = skb_dequeue(&local->skb_queue_unreliable))) {
> switch (skb->pkt_type) {
> case ieee80211_rx_msg:
> - /* get pointer to saved status out of skb->cb */
> - memcpy(&rx_status, skb->cb, sizeof(rx_status));
> + /* status is in skb->cb */
> + rx_status = (struct ieee80211_rx_status *) skb->cb;
> /* Clear skb->type in order to not confuse kernel
> * netstack. */
> skb->pkt_type = 0;
> __ieee80211_rx(local_to_hw(local), skb, rx_status);
Uh, sorry, I haven't noticed it before: you should copy cb to a local
rx_status structure as __ieee80211_rx is allowed to destroy the skb,
yet it still needs the rx_status.
Thanks,
Jiri
--
Jiri Benc
SUSE Labs
next prev parent reply other threads:[~2007-02-09 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 4:59 [PATCH] d80211: remove hosttime from ieee80211_rx_status Michael Wu
2007-02-09 5:50 ` Michael Buesch
2007-02-09 15:56 ` Michael Wu
2007-02-09 17:15 ` Jiri Benc [this message]
2007-02-09 17:47 ` Michael Wu
2007-02-15 21:27 ` Jiri Benc
2007-02-09 14:43 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209181513.66fdec56@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox