Re: [PATCH] zd1211rw: Readd zd_addr_t cast

[Ulrich Kunitz <kune@deine-taler.de>]

On 07-02-10 07:02 Michael Buesch wrote:

> On Saturday 10 February 2007 02:27, Daniel Drake wrote:
> > Robert P.J. Day's recent commit ("getting rid of all casts of k[cmz]alloc()
> > calls") introduced a sparse warning for zd1211rw, related to our type-checking
> > of addresses.
> > 
> > 	zd_chip.c:116:15: warning: implicit cast to nocast type
> > 
> > This patch readds the type cast, it is correct.
> > 
> > Signed-off-by: Daniel Drake <dsd@gentoo.org>
> > 
> > Index: linux/drivers/net/wireless/zd1211rw/zd_chip.c
> > ===================================================================
> > --- linux.orig/drivers/net/wireless/zd1211rw/zd_chip.c
> > +++ linux/drivers/net/wireless/zd1211rw/zd_chip.c
> > @@ -113,7 +113,7 @@ int zd_ioread32v_locked(struct zd_chip *
> >  
> >  	/* Allocate a single memory block for values and addresses. */
> >  	count16 = 2*count;
> > -	a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> > +	a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> >  		                   GFP_NOFS);
> 
> Unrelated, but I am wondering since quite some time why you pass GFP_NOFS here.
> Any special reason? I think in general there is no good reason for code outside
> of the VFS to use this flag.
> IMHO you should pass either GFP_ATOMIC or GFP_KERNEL.

Michael,

you are right. The theory has been to prevent the NFS operations
while being in the kernel. But no driver in drivers/net is using
it. I will exchange it by GFP_KERNEL, this code is protected by a
mutex and is not atomic.

Ciao,

Uli

-- 
Uli Kunitz